Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After renaming zulip topic, post a comment under the old topic pointing to the new topic #1590

Merged
merged 1 commit into from Apr 12, 2022

Conversation

ghost
Copy link

@ghost ghost commented Mar 14, 2022

After renaming zulip topic (#1588), post an additional comment under the old (now empty) topic pointing to the newly renamed topic. Fixes #1228.

Alternative to #1589. Although #1589 could potentially still be applied. it would just be somewhat redundant.

cc @Mark-Simulacrum @apiraino

@apiraino
Copy link
Contributor

that's really cool @skippy10110 , thanks!

@ghost
Copy link
Author

ghost commented Mar 14, 2022

Thanks for the great suggestion!

…the old (now empty) topic pointing to the newly renamed topic. Fixes #1228.
@ghost
Copy link
Author

ghost commented Mar 21, 2022

This might become fixed natively by zulip in zulip/zulip#15290, zulip/zulip@f0c680e !

I just tried it quickly, but I suppose I need to wait for that commit to actually makes its way through to our zulip instance :)

Edit: nevermind :) the topic link portion wasn't fixed and a new issue is up now for that: zulip/zulip#21505

@Mark-Simulacrum
Copy link
Member

Hi! @skippy10110 I'm happy to merge or not merge -- not very clear on the status here. Could you provide an update?

@ghost
Copy link
Author

ghost commented Apr 12, 2022

this is all ready to go on my end if you're fine with the change (with the caveat that i have no way to test the change until it's live)

@ghost
Copy link
Author

ghost commented Apr 12, 2022

i'm not sure if it's actually been reviewed by anyone, if you want to take a look also

@Mark-Simulacrum Mark-Simulacrum merged commit daaf943 into rust-lang:master Apr 12, 2022
@ghost
Copy link
Author

ghost commented Apr 13, 2022

@Mark-Simulacrum, do you know if this should be live yet? I just tried it out and didn't see the new comment post.

@Mark-Simulacrum
Copy link
Member

It should have deployed automatically, but I won't get a chance to check that today most likely.

@Mark-Simulacrum
Copy link
Member

It looks like we weren't successfully deploying (unfortunately, we don't really have alarms for this currently), due to an outdated glibc version. The good news is that for once health checks worked so the previous deployment remained live; the bad news is that this patch didn't actually go out.

With #1612 merged and now deployed this should also be in production now.

@ghost
Copy link
Author

ghost commented Apr 15, 2022

phew 😊 thanks for letting me know, i just tested it out and it's working great!

https://rust-lang.zulipchat.com/#narrow/stream/243200-xxx/topic/TRIAGEBOT.20TESTING.3A.20Please.20ignore.20lang-team.23148

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zulip topic is only renamed for messages after MCP issue rename occurs
3 participants