CI: Only require MSRV-check to succeed with -Zminimal-versions
#443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One of our dependencies recently bumped its `rust-version` causing our MSRV test to _break again_. It is undesired to randomly work around this by bumping our MSRV, or consistently have PRs/merges fail for unrelated reasons. Instead, perform the MSRV-test with `-Zminimal-versions`. This seems to be generally accepted in the Rust ecosystem (as there is otherwise no way for crates to bump MSRV barring a semver-breaking release) and prevents us from hitting unnecessary MSRV build failures caused by dependencies. At the same time our minimal version bounds are now exercised, ensuring downstream crates depending on the `ndk` can build with `-Zminimal-versions` too - which required specifying a few patch bounds for our dependencies. Unfortunately GitHub's UI for `continue-on-error: true` doesn't make it obvious that a step/job really didn't succeed, this is only visible from the annotations. Still, it is relevant to keep track of whether our non-`minimal-versions` build adheres to MSRV.
Getting a bunch of deprecation warnings on the _ancient_ (almost 4 years old) `v1` release.
MarijnS95
force-pushed
the
msrv-minimal-versions
branch
from
030abc8 to
ef75212
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of our dependencies recently bumped its
rust-versioncausing our MSRV test to break again. It is undesired to randomly work around this by bumping our MSRV, or consistently have PRs/merges fail for unrelated reasons.Instead, perform the MSRV-test with
-Zminimal-versions. This seems to be generally accepted in the Rust ecosystem (as there is otherwise no way for crates to bump MSRV barring a semver-breaking release) and prevents us from hitting unnecessary MSRV build failures caused by dependencies.At the same time our minimal version bounds are now exercised, ensuring downstream crates depending on the
ndkcan build with-Zminimal-versionstoo - which required specifying a few patch bounds for our dependencies.Unfortunately GitHub's UI for
continue-on-error: truedoesn't make it obvious that a step/job really didn't succeed, this is only visible from the annotations. Still, it is relevant to keep track of whether our non-minimal-versionsbuild adheres to MSRV.