Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: Move modularization comment down and use new blockquote syntax #447

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

MarijnS95
Copy link
Member

The previous > **Note** syntax has been deprecated in favour of > [!NOTE] sytnax on November 14th (2 days ago), and newer block types were added: https://github.com/orgs/community/discussions/16925

I'm not quite sure if IMPORTANT carries the right load since Crucial information necessary for users to succeed is no longer really applicable; most users know where to find the crates and their names haven't changed on crates.io.

Finally, also mention xbuild being favoured over cargo-apk (even though there's still, after all these years some feature disparity).

The previous `> **Note**` syntax has been deprecated in favour of
`> [!NOTE]` sytnax on November 14th (2 days ago), and newer block types
were added: https://github.com/orgs/community/discussions/16925

I'm not quite sure if `IMPORTANT` carries the right load since `Crucial
information necessary for users to succeed` is no longer really
applicable; most users know where to find the crates and their names
haven't changed on crates.io.

Finally, also mention `xbuild` being favoured over `cargo-apk` (even
though there's _still_, after all these years some feature disparity).
@MarijnS95 MarijnS95 requested a review from rib November 16, 2023 10:26
@MarijnS95
Copy link
Member Author

MarijnS95 commented Nov 16, 2023

Copy link
Contributor

@rib rib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MarijnS95 MarijnS95 merged commit 87acd19 into master Nov 16, 2023
38 checks passed
@MarijnS95 MarijnS95 deleted the readme branch November 16, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants