ndk/hardware_buffer: Convert HardwareBufferUsage to bitflags
#461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
force-pushed
the
hardware-buffer-usage-bitflags
branch
from
24f4d4d to
2dfabcb
Compare
MarijnS95
force-pushed
the
hardware-buffer-usage-bitflags
branch
from
2dfabcb to
901903f
Compare
`HardwareBufferUsage` really is a structure that comprises various usage flags, and was modeled as a hard-to-get `u64` value while being wrapped inside _two_ newtypes (one in the `ndk`, one in `ndk-sys`) and without the typical bit-ops (i.e. `BitOr`) one comes to expect. This is all provided out of the box - and more helper functions - via `bitflags` with more convenient access to the raw value to beat. Also inherit the upstream docs for convenience and completeness.
MarijnS95
force-pushed
the
hardware-buffer-usage-bitflags
branch
from
901903f to
7d0cacd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HardwareBufferUsagereally is a structure that comprises various usage flags, and was modeled as a hard-to-getu64value while being wrapped inside two newtypes (one in thendk, one inndk-sys) and without the typical bit-ops (i.e.BitOr) one comes to expect.This is all provided out of the box - and more helper functions - via
bitflagswith more convenient access to the raw value to beat.Also inherit the upstream docs for convenience and completeness.