Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ndarray and other deps #379

Closed
wants to merge 1 commit into from

Conversation

Dirreke
Copy link
Collaborator

@Dirreke Dirreke commented Aug 5, 2024

Bump ndarray from 0.15.6 to 0.16.0
Bump approx from 0.4.0 to 0.5
Bump criterion from 0.3.4 to 0.5.1

@Dirreke
Copy link
Collaborator Author

Dirreke commented Aug 14, 2024

sorry, I forget to update tests file. I will fix it later today

@Dirreke
Copy link
Collaborator Author

Dirreke commented Aug 14, 2024

Fixed, Let's rerun CI

@bluss
Copy link
Member

bluss commented Aug 14, 2024

hi - I was here to press the ci button but I was wondering if @termoshtt wants to chime in too

@Dirreke
Copy link
Collaborator Author

Dirreke commented Aug 14, 2024

It seems like we should bump MSRV. Or limit the version of clap. Which one would you like?
I could open a new PR to fix it.

@govinda-kamath
Copy link

Hi - any update on this. This seems to be holding back ndarray updates downstream?

@@ -37,7 +37,7 @@ rand = "0.8.3"
thiserror = "1.0.24"

[dependencies.ndarray]
version = "0.15.2"
version = "0.16.0"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version = "0.16.0"
version = ">=0.15.0, <0.17"

This would make it easier to use as a library downstream

@Garfield100
Copy link

@bluss @termoshtt @Dirreke
Bumping this because this issue is quite painful while the fix is simple and a PR is already open and very close to being mergeable.
This crate hasn't received an update in 2 years and is currently unusable with other parts of the ecosystem. Don't let all the hard work which went into ndarray_linalg go to waste :)

@bluss
Copy link
Member

bluss commented Nov 23, 2024

I have been added as a crate owner for this crate on crates.io since today, thanks to @termoshtt for the transfer.

I will help get the next release out as a transition thing - but those that need this package are hereby invited to become maintainers.

@Dirreke
Copy link
Collaborator Author

Dirreke commented Nov 23, 2024

Awesome! Thanks for your contribution. I will close this PR.

@Dirreke Dirreke closed this Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants