updating header to not include multiboot with alloc #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phip1611
approved these changes
Dec 16, 2023
phip1611
force-pushed
the
fix_no_alloc_for_header
branch
from
6d8b399
to
5595f79
Compare
|
Thanks, good catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when using multiboot2-header with no alloc (default-features = false), you wil get
error: no global memory allocator found but one is requirederror. Reason being , when including multiboot2 for MBI tags, it will also include alloc and builder. This patch fixes that so that you can use multiboot2-header as intended without alloc when it is off.