-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Main #68
Merged
Update Main #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add README and .gitignore files
Prefer specific version unless testing that code works with old version
Simplify return types for fallible functions
Move main logic into a module called core to make it clear which parts are executing code
Was getting a warning from crates plugin in vscode saying > The version requirement of the target dependency I couldn't figure out what it meant but keeping it at 0.4.19 wasn't providing any additional value.
Provide more info for debugging and better error messages when things go wrong
Getting quite a few if using debug rn so going to change those in this module to info. Side stepping the problem for now. Can be filtered out instead.
To side step problem of other creates logs showing up
Test had to be updated as top of parser had changed when moving to proper cargo subcommand
Support VecVecString
- Needed for new way of checking if type is a String type
Ensure code also compiles in release mode
Develop was only there for testing
Release Compile Fix
Add contribution guide
…ion-guide Fix typo in CONTRIBUTING.md
Needed for today's problem https://leetcode.com/problems/pseudo-palindromic-paths-in-a-binary-tree
AliciaY-720
approved these changes
Jan 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main has fallen out of sync with Develop bringing it back up to date in preparation for publishing