Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem Solutions #91

Open
wants to merge 16 commits into
base: develop
Choose a base branch
from
Open

Problem Solutions #91

wants to merge 16 commits into from

Conversation

c-git
Copy link
Contributor

@c-git c-git commented Aug 25, 2024

Adds the ability to download the problem descriptions and extracts the solutions from the description to add to the test cases added to the generated code

@c-git c-git requested a review from Antosser August 25, 2024 05:54
@Antosser
Copy link
Contributor

Honestly, I have no idea what I was reading, but all the individual parts looked fine.

Did you leave the .snap files in on purpose? You made a *.snap.new line in .gitignore but it doesn't affect those .snap files

@c-git
Copy link
Contributor Author

c-git commented Aug 25, 2024

Yes the .snap files are there on purpose. They store the value the test is supposed to return. The .snap.new one's are the files used when the test returns something different do that you can compare.

It's not actually very complicated, I'd be happy to explain it if you want. We can do a synchronous call on discord or you can tell me which parts are not clear and I can type the explanation.

@c-git c-git force-pushed the problem_solutions branch from 5b45a15 to d9b5e2d Compare August 25, 2024 15:44
@c-git c-git linked an issue Aug 25, 2024 that may be closed by this pull request
@c-git
Copy link
Contributor Author

c-git commented Aug 25, 2024

The tests added to src/tool/core/generate.rs add snapshot testing for the generate output that was desired in #47

@c-git c-git linked an issue Aug 25, 2024 that may be closed by this pull request
@c-git c-git requested a review from Antosser September 20, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add snapshot testing for lib Solutions to examples
2 participants