-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fn map_values(…)
method to Tree<T>
#36
Conversation
The Clippy lint is unrelated to your change but could fix it nevertheless? Thanks! |
Done. |
I'll give it some time for anybody else to have a look and merge if happy. Otherwise I'll merge it tomorrow. |
@adamreichold is there a chance to get a release cut with this? |
@cfvescovo Would you be up to releasing the current state of affairs as 0.9.1? |
I may have to do some git tricks to release your fix as 0.9.1 and then the current state (with sort) as 0.10.0. If it's okay for you I will do it this evening (CET time) |
If you aim for that, then just release 0.10.0 and we'll bump scraper as well. I was suggesting 0.9.1 because we are 0.x and did not make any incompatible changes, i.e. even |
Ok, so I will release 0.10.0. I like keeping patch version bumps for hot fixes |
I needed to map trees from one node value type to another and implementing such a mapping via the existing public API was sub-optimal, while with access to the internals it turned out to be trivial.