-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cap: Skip compiling SetGuestDebug for RISC-V at the moment #236
Conversation
RISC-V currently doesn't support KVM_CAP_SET_GUEST_DEBUG. Signed-off-by: Tan En De <[email protected]>
65613cf
to
ef012d4
Compare
Add linker for `--target=riscv64gc-unknown-linux-gnu`. Signed-off-by: Tan En De <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! - I validated this against the KVM API documentation.
@andreeaflorescu Will the merge commit go away when "Rebase & merge" is pressed? I never know as it's not part of my usual workflow. |
Yes, that's why I am using it because it keeps the approvals at no cost. |
@rbradford the reason why that goes away is because the merge strategy for PRs is rebase & merge. You can see that no rebase commit was added when I merged this: https://github.com/rust-vmm/kvm-ioctls/commits/main |
Cool, I thought that would happen - I guess the only time the merge commit would stay around is if it contained changes to resolve a merge conflict - and that is not something that the would happen with the web ui update branch button. |
yap, that's true! |
RISC-V currently doesn't support KVM_CAP_SET_GUEST_DEBUG.
Summary of the PR
Related: #208
With the conditional compilation, compilation using
riscv64gc-unknown-linux-gnu
is successful.Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s
), and the commitmessage has max 60 characters for the summary and max 75 characters for each
description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafe
code is properly documented.