Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update syscall to 6.12 #78

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

RuoqingHe
Copy link
Member

Summary of the PR

  • syscall_table: Update to v6.12 kernel syscall
  • CHANGELOG: Update CHANGELOG.md

Requirements

Before submitting your PR, please make sure you addressed the following
requirements:

  • All commits in this PR have Signed-Off-By trailers (with
    git commit -s), and the commit message has max 60 characters for the
    summary and max 75 characters for each description line.
  • All added/changed functionality has a corresponding unit/integration
    test.
  • All added/changed public-facing functionality has entries in the "Upcoming
    Release" section of CHANGELOG.md (if no such section exists, please create one).
  • Any newly added unsafe code is properly documented.

@RuoqingHe
Copy link
Member Author

Could @alindima @roypat @rbradford take a look when convenient 🙂

roypat
roypat previously approved these changes Feb 10, 2025
Copy link
Collaborator

@alindima alindima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but the syscall table validation is failing in the CI for aarch64. is there something wrong with the script? Looks like it's comparing syscall tables of different architectures

@RuoqingHe
Copy link
Member Author

LGTM, but the syscall table validation is failing in the CI for aarch64. is there something wrong with the script? Looks like it's comparing syscall tables of different architectures

Yes, tools/generate_syscall_tables.sh does work with recent kernel anymore, I'm working converting this script as a part of header-gen (a tiny program going to be integrated in rust-vmm-ci) since in other repos we are doing something similar.

@RuoqingHe
Copy link
Member Author

Can we merge this now @alindima 🙂 for works to be finished in rust-vmm-ci could take a while

@alindima
Copy link
Collaborator

Hmm, but if you're saying that the script does not for recent kernel versions, how did you generate the tables in the first place? which script did you use?

Can you detail a bit what is the problem with the new kernel? Is there a relevant PR in rust-vmm-ci?

@RuoqingHe
Copy link
Member Author

RuoqingHe commented Feb 13, 2025

Hmm, but if you're saying that the script does not for recent kernel versions, how did you generate the tables in the first place? which script did you use?

Can you detail a bit what is the problem with the new kernel? Is there a relevant PR in rust-vmm-ci?

Noted, let me re-organize my code and raise a PR to rust-vmm-ci. Then I'll get back to you

@RuoqingHe
Copy link
Member Author

@alindima A prototype is available here: rust-vmm/rust-vmm-ci#177, you can verify the generated code through command:

rustvmm_gen/rustvmm_gen.py --arch arm64 --version 6.12.8 generate_syscall

@RuoqingHe
Copy link
Member Author

Since the validation could take a while to resolve, can I propose to release 0.5.0 of seccompiler as it is now 🤔

It's blocking our downstream from launching RISC-V support 🥹

@RuoqingHe RuoqingHe force-pushed the update-syscall-to-6.12 branch 3 times, most recently from 9a16f29 to cd1de38 Compare March 5, 2025 10:02
Code structure reorganized. Now we need to install headers for each
architecture, and extract the syscalls from `unistd_64.h`.

Signed-off-by: Ruoqing He <[email protected]>
Some of our downstream communities are moving to 6.12 kernel,
regenerated `syscall_table` from 6.12 kernel source to catch up.

Signed-off-by: Ruoqing He <[email protected]>
Update `CHANGELOG.md` and document the update of `syscall_tables` from
v6.12 kernel source.

Signed-off-by: Ruoqing He <[email protected]>
@RuoqingHe RuoqingHe force-pushed the update-syscall-to-6.12 branch from cd1de38 to 96e37e4 Compare March 5, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants