Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows: Fix the event loop to wake on accessibility requests #4058

Merged
merged 3 commits into from
Dec 23, 2024

Conversation

mwcampbell
Copy link
Contributor

Fixes #4055.

It turns out this is easy to test even though AccessKit doesn't yet support winit master. If you run the window example on Windows with the NVDA screen reader running without this fix, NVDA doesn't read the window title, or reads it with a severe delay. With this fix, it reads the window title immediately as expected, even though the application doesn't implement accessibility.

  • Tested on all platforms changed
  • Added an entry to the changelog module if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality

@mwcampbell mwcampbell requested a review from notgull as a code owner December 23, 2024 21:06
src/changelog/unreleased.md Outdated Show resolved Hide resolved
Co-authored-by: Kirill Chibisov <[email protected]>
@kchibisov
Copy link
Member

From what I've seen on how options work in docs, the new one just adds SEND_MESSAGE, which I guess is what is used by 3rd party software to communicate stuff, so it's just broader version of what we've used before, thus should be fine.

@kchibisov kchibisov added this to the Version 0.30.8 milestone Dec 23, 2024
@mwcampbell
Copy link
Contributor Author

Yes, QS_ALLINPUT is a superset of QS_ALLEVENTS, so it just wakes on more types of messages.

@kchibisov kchibisov merged commit 6896de5 into rust-windowing:master Dec 23, 2024
58 checks passed
@kchibisov
Copy link
Member

Thanks, I'll wait for a couple of days and then make a new release if it's fine with you. It's holidays for the majority, so shouldn't really matter.

If you need release asap I can cut it though.

@mwcampbell
Copy link
Contributor Author

I don't need a release for anything I'm doing. I just hope that nobody upgrades winit and breaks their app's accessibility in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

windows: Use of MsgWaitForMultipleObjects breaks accessibility
2 participants