Skip to content

Commit

Permalink
feat: add TODO comments for refactoring merge method in Summary
Browse files Browse the repository at this point in the history
Signed-off-by: simonsan <[email protected]>
  • Loading branch information
simonsan committed Nov 25, 2024
1 parent efb345e commit bbafe09
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions crates/core/src/error/summary.rs
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,14 @@ impl Summary {
Ok(())
}

// ! TODO: Refactor this method to merge the context of each summary
// !
// ? How do we merge the context of each summary?
// ? We can't merge the context, as it's a unique identifier for each summary.
// ? We could add a new field to each CondensedIssue to store the context of the
// ? merged summaries.
// ?
// ? How do we merge the other fields? E.g. Timing, Metrics, etc.
pub fn merge(&mut self, other: Summary) {
self.issues.extend(other.issues);
self.metrics.extend(other.metrics);
Expand Down

0 comments on commit bbafe09

Please sign in to comment.