feat: Add methods for repairing hot/cold repositories #255

aawsome · 2024-09-04T08:22:19Z

No description provided.

codecov · 2024-09-04T08:32:46Z

Codecov Report

Attention: Patch coverage is 13.22314% with 105 lines in your changes missing coverage. Please review.

Project coverage is 40.5%. Comparing base (22a898c) to head (7343ef5).

Files with missing lines	Patch %	Lines
crates/core/src/commands/repair/hotcold.rs	0.0%	83 Missing ⚠️
crates/core/src/repository.rs	38.8%	22 Missing ⚠️

Additional details and impacted files

Files with missing lines	Coverage Δ
crates/core/src/commands/config.rs	`25.9% <100.0%> (+1.6%)`	⬆️
crates/core/src/commands/init.rs	`93.7% <ø> (ø)`
crates/core/src/repository.rs	`41.2% <38.8%> (-0.5%)`	⬇️
crates/core/src/commands/repair/hotcold.rs	`0.0% <0.0%> (ø)`

... and 16 files with indirect coverage changes

---- 🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests

simonsan · 2024-11-19T20:46:51Z

Merged main into it, because the test coverage failure is fixed there.

aawsome · 2024-11-19T21:51:48Z

The failing test is due to missing tests...

simonsan · 2024-11-19T23:36:00Z

The failing test is due to missing tests...

I meant before 😅

simonsan · 2024-11-19T23:37:25Z

crates/core/src/commands/init.rs

-/// * `config` - The config to use.
+/// * `repo` - The repository to save the config to
+/// * `new_config` - The config to save
+/// * `key` - The key to encrypt the config with


Suggested change

/// * `key` - The key to encrypt the config with

/// * `key_opts` - The options to create the key with.

simonsan · 2024-11-19T23:37:54Z

crates/core/src/commands/init.rs

-/// # Returns
+/// # Errors
+///
+/// * [`CryptBackendErrorKind::SerializingToJsonByteVectorFailed`] - If the file could not be serialized to json.


Suggested change

/// * [`CryptBackendErrorKind::SerializingToJsonByteVectorFailed`] - If the file could not be serialized to json.

/// * If the file could not be serialized to json.

simonsan · 2024-11-19T23:38:19Z

crates/core/src/commands/init.rs

 ///
-/// The key used to encrypt the config.
+/// [`CryptBackendErrorKind::SerializingToJsonByteVectorFailed`]: crate::error::CryptBackendErrorKind::SerializingToJsonByteVectorFailed


Suggested change

/// [`CryptBackendErrorKind::SerializingToJsonByteVectorFailed`]: crate::error::CryptBackendErrorKind::SerializingToJsonByteVectorFailed

simonsan · 2024-11-19T23:38:58Z

crates/core/src/commands/repair.rs

@@ -1,2 +1,3 @@
+pub mod hotcold;


Suggested change

pub mod hotcold;

pub mod hot_cold;

I think two separate words value an underscore.

simonsan · 2024-11-19T23:39:15Z

crates/core/src/commands/repair/hotcold.rs

+    RusticResult, WriteBackend, ALL_FILE_TYPES,
+};
+
+pub(crate) fn repair_hotcold<P: ProgressBars, S>(


Suggested change

pub(crate) fn repair_hotcold<P: ProgressBars, S>(

pub(crate) fn repair_hot_cold<P: ProgressBars, S>(

same

A bit of documentation for this new function would be lovely as well 🚀

simonsan · 2024-11-19T23:40:59Z

crates/core/src/commands/repair/hotcold.rs

+    Ok(())
+}
+
+pub(crate) fn get_tree_packs<P: ProgressBars, S: Open>(


A bit of documentation for this new function would be lovely as well 🚀

simonsan · 2024-11-19T23:41:04Z

crates/core/src/commands/repair/hotcold.rs

+    Ok(tree_packs)
+}
+
+pub(crate) fn get_missing_files<P: ProgressBars, S>(


A bit of documentation for this new function would be lovely as well 🚀

simonsan · 2024-11-19T23:41:30Z

crates/core/src/repository.rs

+    ///
+    /// # Errors
+    ///
+    /// * [`CryptBackendErrorKind::SerializingToJsonByteVectorFailed`] - If the file could not be serialized to json.


Suggested change

/// * [`CryptBackendErrorKind::SerializingToJsonByteVectorFailed`] - If the file could not be serialized to json.

/// * If the file could not be serialized to json.

C&P, please check if the errors make sense

simonsan · 2024-11-19T23:41:41Z

crates/core/src/repository.rs

+    ///
+    /// [`CryptBackendErrorKind::SerializingToJsonByteVectorFailed`]: crate::error::CryptBackendErrorKind::SerializingToJsonByteVectorFailed


Suggested change

///

/// [`CryptBackendErrorKind::SerializingToJsonByteVectorFailed`]: crate::error::CryptBackendErrorKind::SerializingToJsonByteVectorFailed

simonsan · 2024-11-19T23:42:20Z

crates/core/src/repository.rs

+    ///
+    /// # Type Parameters
+    ///
+    /// * `P` - The progress bar type.
+    /// * `S` - The state the repository is in.
+    ///
+    /// # Arguments
+    ///
+    /// * `repo` - The repository to save the config to
+    /// * `new_config` - The config to save
+    /// * `key` - The key to encrypt the config with


Suggested change

///

/// # Type Parameters

///

/// * `P` - The progress bar type.

/// * `S` - The state the repository is in.

///

/// # Arguments

///

/// * `repo` - The repository to save the config to

/// * `new_config` - The config to save

/// * `key` - The key to encrypt the config with

simonsan · 2024-11-19T23:43:33Z

First read through, for raw structure. Will read through it again for typos and impl.

EDIT: Can help fix the docs

aawsome mentioned this pull request Sep 4, 2024

feat: Add init --hot-only option rustic-rs/rustic#1224

Open

1 task

aawsome changed the title ~~WIP: feat: Add methods for repairing hot/cold repositories~~ feat: Add methods for repairing hot/cold repositories Sep 6, 2024

WIP: feat: Add methods for repairing hot/cold repositories

1b5fb66

aawsome force-pushed the repair-hotcold branch 2 times, most recently from 9327d83 to 1b5fb66 Compare November 19, 2024 16:41

Merge branch 'main' into repair-hotcold

7343ef5

aawsome marked this pull request as ready for review November 19, 2024 23:37

simonsan reviewed Nov 19, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add methods for repairing hot/cold repositories #255

feat: Add methods for repairing hot/cold repositories #255

aawsome commented Sep 4, 2024

codecov bot commented Sep 4, 2024 •

edited

Loading

simonsan commented Nov 19, 2024

aawsome commented Nov 19, 2024

simonsan commented Nov 19, 2024

simonsan Nov 19, 2024

simonsan Nov 19, 2024

simonsan Nov 19, 2024

simonsan Nov 19, 2024

simonsan Nov 19, 2024

simonsan Nov 19, 2024

simonsan Nov 19, 2024

simonsan Nov 19, 2024

simonsan Nov 19, 2024

simonsan Nov 19, 2024

simonsan Nov 19, 2024

simonsan Nov 19, 2024

simonsan commented Nov 19, 2024 •

edited

Loading

	/// * `key` - The key to encrypt the config with
	/// * `key_opts` - The options to create the key with.

	/// * [`CryptBackendErrorKind::SerializingToJsonByteVectorFailed`] - If the file could not be serialized to json.
	/// * If the file could not be serialized to json.

	pub(crate) fn repair_hotcold<P: ProgressBars, S>(
	pub(crate) fn repair_hot_cold<P: ProgressBars, S>(

		///
		/// [`CryptBackendErrorKind::SerializingToJsonByteVectorFailed`]: crate::error::CryptBackendErrorKind::SerializingToJsonByteVectorFailed

feat: Add methods for repairing hot/cold repositories #255

Are you sure you want to change the base?

feat: Add methods for repairing hot/cold repositories #255

Conversation

aawsome commented Sep 4, 2024

codecov bot commented Sep 4, 2024 • edited Loading

Codecov Report

simonsan commented Nov 19, 2024

aawsome commented Nov 19, 2024

simonsan commented Nov 19, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

simonsan commented Nov 19, 2024 • edited Loading

codecov bot commented Sep 4, 2024 •

edited

Loading

simonsan commented Nov 19, 2024 •

edited

Loading