Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hold back version of time crate to 0.3.23 to support Rust 1.66 #144

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

iamjpotts
Copy link
Contributor

Latest version of time create has a higher minimum rust version that rcgen does.

Limit the version of time to the latest version with a minimum rust version compatible with rcgen.

@iamjpotts
Copy link
Contributor Author

Build failure related to parsing a revoked certificate might be fixed by #142.

@est31
Copy link
Member

est31 commented Aug 25, 2023

Needs a rebase, but otherwise looks good.

Copy link
Member

@est31 est31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also does a cargo update, which is a good idea as we haven't done one in a long time. In general, doing cargo update is not really useful though, as it incurs a cost in terms of requiring us to rebuild a large chunk of dependencies each time there is an update.

@est31 est31 merged commit 270702b into rustls:master Aug 25, 2023
6 checks passed
@rukai
Copy link
Contributor

rukai commented Aug 28, 2023

This change will break my build.
I stumbled across this change and was concerned because I've seen these kinds of version restrictions break things many times.
So I tried pointing my project to the latest rcgen git and sure enough:
image

Please do not introduce fragility into version resolution in order to satisfy MSRV.
If you really want to maintain MSRV you could keep CI passing by relying on your Cargo.lock to pull in the right time version and then expect users to do the same.

@djc djc mentioned this pull request Aug 28, 2023
@est31
Copy link
Member

est31 commented Aug 28, 2023

@rukai I think the time maintainers would be interested in your user report: time-rs/time#592

@djc
Copy link
Member

djc commented Aug 28, 2023

@rukai see #148.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants