Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.11.2 #160

Merged
merged 2 commits into from
Sep 21, 2023
Merged

Release 0.11.2 #160

merged 2 commits into from
Sep 21, 2023

Conversation

est31
Copy link
Member

@est31 est31 commented Sep 20, 2023

Closes #156.

This is the first release of rcgen at its new home in the rustls github organization. I want to use this opportunity to thank @cpu , @djc and the other rustls members for their help with maintaining rcgen and letting rcgen join the rustls organization.

@est31 est31 requested a review from cpu September 20, 2023 22:10
Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉🥳

@est31
Copy link
Member Author

est31 commented Sep 20, 2023

The CI failure is legit... seems due to a problem with the new webpki release which added the budget param to a public function?


error[E0061]: this method takes 3 arguments but 2 arguments were supplied
   --> tests/webpki.rs:542:4
    |
542 |         .verify_signature(&[&webpki::ECDSA_P256_SHA256], &raw_spki.value())
    |          ^^^^^^^^^^^^^^^^-------------------------------------------------- an argument of type `&mut webpki::verify_cert::Budget` is missing
    |
note: method defined here
   --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rustls-webpki-0.101.5/src/crl.rs:42:8
    |
42  |     fn verify_signature(
    |        ^^^^^^^^^^^^^^^^
help: provide the argument
    |
542 |         .verify_signature(&[&webpki::ECDSA_P256_SHA256], &raw_spki.value(), /* &mut webpki::verify_cert::Budget */)
    |                          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

@cpu
Copy link
Member

cpu commented Sep 20, 2023

The CI failure is legit... seems due to a problem with the new webpki release which added the budget param to a public function?

@est31 Looks like I broke semver backporting that to 0.101.x without realizing it 😿 I will work on cutting a new point release that undoes that mistake, but I won't be able to do it until ~tomorrow. Thanks for flagging the issue.

Edit: filed rustls/webpki#185 for this.

@cpu
Copy link
Member

cpu commented Sep 21, 2023

Looks like I broke semver backporting that to 0.101.x without realizing it

This is fixed in 0.101.6, and 0.101.5 is yanked.

@est31 est31 added this pull request to the merge queue Sep 21, 2023
Merged via the queue into main with commit 0c8cfc7 Sep 21, 2023
28 checks passed
@est31 est31 deleted the release-0.11.2 branch September 21, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish a 0.11.2 release
2 participants