Skip to content

Commit

Permalink
ci: use default Android emulator target
Browse files Browse the repository at this point in the history
Previously the Android emulator based CI job was using the larger
`googles_api` target instead of the slimmer default. This was done to
ensure network access worked as intended for the real-world test suite
with a TODO to revisit after an upstream bug was fixed.

In the meantime the upstream bug has been closed and we've upgraded the
emulator action version. Let's try the default target again and
hopefully get a small CI speedup.
  • Loading branch information
cpu committed Mar 12, 2024
1 parent d68c2ed commit 8a0baee
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -144,13 +144,6 @@ jobs:
api-level: 28 # Android 9, Pie.
arch: x86_64
profile: pixel
# Note: We use the `google_apis` target because the default one doesn't have access to
# the internet for the real-world test suite. The intermediate certificate doesn't have
# stapled revocation data, so the system must look it up instead.
#
# This can use the default target (which is less bloated) once
# https://github.com/ReactiveCircus/android-emulator-runner/issues/220 is resolved.
target: google_apis
emulator-options: -no-snapshot-save -no-window -gpu swiftshader_indirect -noaudio -no-boot-anim -camera-back none
disable-animations: true
working-directory: ./android
Expand Down

0 comments on commit 8a0baee

Please sign in to comment.