Update pqcrypto-internals build.rs to support iOS SDK 18.1 #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasPukenis
added a commit
to NordSecurity/libtelio
that referenced
this pull request
Jan 9, 2025
Darwin runners fail after the update of this crate which is a transient dependency. Using `[patch]` doesn't update properly so this is a manual attempt. There's outstanding PR which claims to fix the issue: rustpq/pqcrypto#72 The error in question from compilation: ``` cargo:warning=<instantiation>:79:5: error: instruction requires: sha3 ``` Signed-off-by: Lukas Pukenis <[email protected]>
3 tasks
LukasPukenis
added a commit
to NordSecurity/libtelio
that referenced
this pull request
Jan 9, 2025
Darwin runners fail after the update of this crate which is a transient dependency. Using `[patch]` doesn't update properly so this is a manual attempt. There's outstanding PR which claims to fix the issue: rustpq/pqcrypto#72 The error in question from compilation: ``` cargo:warning=<instantiation>:79:5: error: instruction requires: sha3 ``` Signed-off-by: Lukas Pukenis <[email protected]>
thomwiggers
approved these changes
Jan 19, 2025
thomwiggers
force-pushed
the
build_ios_sdk_18_1
branch
from
86762e3 to
7fcb107
Compare
auto-merge was automatically disabled
January 24, 2025 13:47
Head branch was pushed to by a user without write access
|
@gridbox Thank you very much for this fix, this worked for me and fixed the compiling issue when trying to build for |
thomwiggers
requested changes
Jan 28, 2025
thomwiggers
force-pushed
the
build_ios_sdk_18_1
branch
from
e4fe2d7 to
e3b6f66
Compare
thomwiggers
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was still experiencing
sha3error even with version 0.2.7. I noticed the OP in #68 was using iOS SDK 17.2. I have since updated to Xcode 16 which is at iOS SDK 18.1 and the build flag did not fix it. However, through some searching I found that updating the build flag to-march=armv8-a+sha3seems to work.Unfortunately, I'm not using the library directly but it is an indirect dependency of another dependency that I am using to build a Flutter mobile app backed by a custom Rust library. I'm not sure if my fix is universal or is just appropriate for my specific use case.