Skip to content

Commit

Permalink
Report insecure cryptography in magic-crypt
Browse files Browse the repository at this point in the history
  • Loading branch information
frozolotl committed Dec 28, 2024
1 parent b02b7ca commit 1768807
Showing 1 changed file with 34 additions and 0 deletions.
34 changes: 34 additions & 0 deletions crates/magic-crypt/RUSTSEC-0000-0000.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
```toml
[advisory]
id = "RUSTSEC-0000-0000"
package = "magic-crypt"
date = "2024-12-28"
url = "https://github.com/magiclen/rust-magiccrypt/issues/17"
categories = ["crypto-failure"]
keywords = ["crypto", "unsound"]

[versions]
patched = []
```

# Use of insecure cryptographic algorithms

This crate uses a number of cryptographic algorithms that are no longer
considered secure and it uses them in ways that do not guarantee the integrity
of the encrypted data.

`MagicCrypt64` uses the insecure DES block cipher in CBC mode without
authentication. This allows for practical brute force and padding oracle
attacks and does not protect the integrity of the encrypted data. Key and IV
are generated from user input using CRC64, which is not at all a key derivation
function.

`MagicCrypt64`, `MagicCrypt128`, `MagicCrypt192`, and `MagicCrypt256` are all
vulnerable to padding-oracle attacks. None of them protect the integrity of the
ciphertext. Furthermore, none use password-based key derivation functions, even
though the key is intended to be generated from a password.

Each of the implementations are unsound in that they use uninitialized memory
without `MaybeUninit` or equivalent structures.

For more information, visit the [issue](https://github.com/magiclen/rust-magiccrypt/issues/17).

0 comments on commit 1768807

Please sign in to comment.