Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unmaintained typemap #1406

Merged
merged 4 commits into from
Sep 8, 2022

Conversation

pinkforest
Copy link
Contributor

@pinkforest pinkforest commented Sep 1, 2022

reem/rust-typemap#45, #1390, #1088

@DoumanAsh would you mind reviewing this advisory ?

I know it was few years ago you started working on ttmap but seems it's been kept up to date ? last release 8 months ago

  • ttmap - crates - 2,638 downloads
  • typemap_rev - 417,116 downloads, ~1k a day
  • typemap - crates - 3,874,814 downloads, ~4k a day_

@No9 would you be publishing your typemap fork + unsafe-any in crates.io so we can perhaps point to it as well ? thx

Also @philip-peterson mind reviewing as this is associated crate

@pinkforest pinkforest added Unmaintained Informational / Unmaintained Feedback Needs more feedback labels Sep 1, 2022
@No9
Copy link

No9 commented Sep 1, 2022

Will do - Busy tomorrow but should get to it over the weekend.

@pinkforest
Copy link
Contributor Author

Also @acdenisSK @bdashore3 I am assuming that you will be maintaining https://crates.io/crates/typemap_rev ?

Trying to round up all these different forks / new impls and give as wide variety of possible alternatives

@bdashore3
Copy link

Hey there! Yes, acdenis and I are maintainers of the typemap_rev crate.

@DoumanAsh
Copy link

@pinkforest yes, I use ttmap for personal projects so it is maintained.
But it is minimalistic which is enough for me hence there is not much to update

@philip-peterson
Copy link

@pinkforest unfortunately I can only commit to the first crate, since it's minimal enough. Actually I don't use either one, but the first one seems simple enough to merge PRs and reply to issues on.

@No9
Copy link

No9 commented Sep 3, 2022

An updated version of typemap is now available in orphanage-rs https://github.com/orphanage-rs/rust-typemap

@Nemo157
Copy link
Contributor

Nemo157 commented Sep 5, 2022

It's likely worth mentioning that there are outstanding forward-compat-warnings too, so the crate is likely to stop compiling one day.

@pinkforest pinkforest removed the Feedback Needs more feedback label Sep 8, 2022
@pinkforest
Copy link
Contributor Author

Thanks all :) I've added y'all feedback in 💜

@pinkforest pinkforest merged commit e5b2ecc into rustsec:main Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Unmaintained Informational / Unmaintained
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants