Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unmaintained multi_mut #1553

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Add unmaintained multi_mut #1553

merged 2 commits into from
Dec 4, 2024

Conversation

pinkforest
Copy link
Contributor

Fixes #1531

It has no dependants so I think unmaintained can do it ?

Ping: rust-lang/rust#39155

@pinkforest pinkforest added Unmaintained Informational / Unmaintained Propose-Merge Propose-Merge labels Feb 1, 2023
@pinkforest pinkforest requested a review from Shnatsel February 2, 2023 11:35
@Shnatsel
Copy link
Member

Shnatsel commented Feb 2, 2023

Thanks for putting this together!

I'd consider "unsound" a stronger warning than "unmaintained", so I'd prefer to go with that. "Unmaintained" was originally created for a crate with no known issues but maintainers MIA, rustcrypto.

Any objections? Should we update the maintainer's guide with that?

@pinkforest
Copy link
Contributor Author

pinkforest commented Feb 2, 2023

We could have combined status for unmaintained and suspect unsound we can't get the maintainer input on ?

Otherwise it's split between two advisories or have this potential source of confusion ?

I don't mind using unsound either though.

@Shnatsel
Copy link
Member

Shnatsel commented Feb 2, 2023

I think an advisory without a patched version is a strong enough signal that the crate isn't maintained well.

@tarcieri thoughts?

@tarcieri
Copy link
Member

You can file separate advisories for both issues

@Shnatsel Shnatsel merged commit ec8a848 into rustsec:main Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Propose-Merge Propose-Merge Unmaintained Informational / Unmaintained
Projects
None yet
Development

Successfully merging this pull request may close these issues.

multi_mut is unsound
4 participants