Move Assets to RuuviLocalization #1847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: avoid duplicate assets, easy to import compile time safe usage
priyonto
reviewed
Jan 6, 2024
Comment on lines
345
to
346
| case .weatherProvider: | ||
| dataSourceIconView.image = RuuviAssets.weatherProviderImage | ||
| dataSourceIconView.image = RuuviAsset.iconWeatherstation.image |
There was a problem hiding this comment.
This can be a separate card but I think we don't need this anymore since virtual sensors are dead.
priyonto
reviewed
Jan 6, 2024
Comment on lines
339
to
342
| case .heartbeat: | ||
| dataSourceIconView.image = RuuviAssets.heartbeatImage | ||
| dataSourceIconView.image = RuuviAsset.iconBluetoothConnected.image | ||
| case .log: | ||
| dataSourceIconView.image = RuuviAssets.heartbeatImage | ||
| dataSourceIconView.image = RuuviAsset.iconBluetoothConnected.image |
There was a problem hiding this comment.
Could have been combined, not sure why I did not do it. 😂
priyonto
reviewed
Jan 6, 2024
Comment on lines
748
to
749
| case .weatherProvider: | ||
| dataSourceIconView.image = RuuviAssets.weatherProviderImage | ||
| dataSourceIconView.image = RuuviAsset.iconWeatherstation.image |
priyonto
reviewed
Jan 6, 2024
Comment on lines
742
to
745
| case .heartbeat: | ||
| dataSourceIconView.image = RuuviAssets.heartbeatImage | ||
| dataSourceIconView.image = RuuviAsset.iconBluetoothConnected.image | ||
| case .log: | ||
| dataSourceIconView.image = RuuviAssets.heartbeatImage | ||
| dataSourceIconView.image = RuuviAsset.iconBluetoothConnected.image |
priyonto
reviewed
Jan 6, 2024
Comment on lines
436
to
438
| dataSourceIconView.image = RuuviAssets.heartbeatImage | ||
| dataSourceIconView.image = RuuviAsset.iconBluetoothConnected.image | ||
| case .log: | ||
| dataSourceIconView.image = RuuviAssets.heartbeatImage | ||
| dataSourceIconView.image = RuuviAsset.iconBluetoothConnected.image |
priyonto
reviewed
Jan 6, 2024
Comment on lines
441
to
442
| case .weatherProvider: | ||
| dataSourceIconView.image = RuuviAssets.weatherProviderImage | ||
| dataSourceIconView.image = RuuviAsset.iconWeatherstation.image |
priyonto
reviewed
Jan 6, 2024
Comment on lines
386
to
389
| case .heartbeat: | ||
| dataSourceIconView.image = RuuviAssets.heartbeatImage | ||
| dataSourceIconView.image = RuuviAsset.iconBluetoothConnected.image | ||
| case .log: | ||
| dataSourceIconView.image = RuuviAssets.heartbeatImage | ||
| dataSourceIconView.image = RuuviAsset.iconBluetoothConnected.image |
priyonto
reviewed
Jan 6, 2024
Comment on lines
392
to
393
| case .weatherProvider: | ||
| dataSourceIconView.image = RuuviAssets.weatherProviderImage | ||
| dataSourceIconView.image = RuuviAsset.iconWeatherstation.image |
priyonto
reviewed
Jan 6, 2024
Comment on lines
4
to
5
| "idiom" : "universal", | ||
| "filename" : "info_icon.png" | ||
| "filename" : "web-ruuvi-eye-nega.pdf", | ||
| "idiom" : "universal" |
There was a problem hiding this comment.
removed this icon as not used
priyonto
reviewed
Jan 6, 2024
|
|
||
| // swiftlint:disable identifier_name line_length nesting type_body_length type_name | ||
| public enum RuuviAsset { | ||
| public enum Resources { |
There was a problem hiding this comment.
I would rename it OnboardingResources since they group the onboarding assets.
priyonto
approved these changes
Jan 6, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: avoid duplicate assets, easy to import compile time safe usage