Don't support transferring Ruuvi Station data on device change #1852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
introduces the migrateIfNeeded function, designed to modify the backup behavior of a specific SQLite database file used within the app. The primary objective is to ensure that this database file is not included in the iCloud backups.
introduces a change in the configuration of a Keychain instance used in the app, specifically targeting the way the app handles the accessibility of the stored keychain items.
The significant change in this pull request is the modification of the keychain's accessibility attribute from .afterFirstUnlock to .afterFirstUnlockThisDeviceOnly. This change impacts when the keychain items become accessible:
Previously: .afterFirstUnlock - The keychain items were accessible after the device was first unlocked following a restart. This level allows the items to be accessible even when the device is locked again, as long as it hasn't been restarted.
Now: .afterFirstUnlockThisDeviceOnly - This setting is similar to .afterFirstUnlock in terms of accessibility after the device's first unlock. However, it adds an additional restriction that the items are only accessible on the current device. This means the keychain items are not included in device backups and cannot be restored to a new device.