Fix (Royalty) transport ships #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, sending a transport ships in some circumstances (like summoning one through royal permits) would result in them disappearing with all pawns and items they carry when arriving at their destinations. The issue was caused due to transport ships themselves not being registered in shared cross refs, which caused them to fail syncing them as IExposable.
SokyranTheDragon
added
bug
|
Is it this issue? #369 |
|
Seems like it is, as the logs are from 1.4. There was a basically identical issue in 1.2-1.3, but the shuttles were handled differently back then so solution would have been different back then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, sending a transport ships in some circumstances (like summoning one through royal permits) would result in them disappearing with all pawns and items they carry when arriving at their destinations.
The issue was caused due to transport ships themselves not being registered in shared cross refs, which caused them to fail syncing them as IExposable.