Added rule to load before Vanilla Expanded Framework #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a minor change that shouldn't really affect anything. The main purpose of this is to try and enforce more proper load order, similarly to the reason we list HugsLib as a mod that we should load before. HugsLib is no longer receiving support and contains some issues, and some mods are dropping it as dependency due to this. Meanwhile Vanilla Expanded Framework is seeing more and more use - be it from new Vanilla Expanded mods, or even unrelated mods that are using it for its features - is
SokyranTheDragon
added
low priority
|
I think it should only be put on MPCompat instead. Since MPCompat requires to be after MP, it'll always be enforced. I don't think people that play modded games are going to play without MPCompat. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor change that shouldn't really affect anything. The main purpose of this is to try and enforce more proper load order, similarly to the reason we list HugsLib as a mod that we should load before. It may not be a perfect solution, but it'll definitely help for players unaware of the position MP should take, or those who only use built-in sorting functionality.
HugsLib is no longer receiving support and contains some bugs, and some mods are dropping it as dependency due to this. Meanwhile Vanilla Expanded Framework is seeing more and more use - be it from new Vanilla Expanded mods, or even unrelated mods that are using it for its features. It'll very likely keep getting supported, so it should stay relevant for long.