Stop excluding "MakeBombardmentMote" from mote patches #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was excluded due to it calling `MakeBombardmentMote_NewTmp`, which would cause warnings from Harmony. However, at some point the `_NewTmp` method was removed (it's not there in the latest 1.4 release). The exception to the patches can now be removed without HugsLib complaining.
SokyranTheDragon
added a commit
to SokyranTheDragon/Multiplayer
that referenced
this pull request
May 11, 2024
rwmt#460, but for 1.4 version of the game.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was excluded due to it calling
MakeBombardmentMote_NewTmp, which would cause warnings from Harmony. However, at some point the_NewTmpmethod was removed (it's not there in the latest 1.4 release). The exception to the patches can now be removed without HugsLib complaining.