Patch for UndercaveMapComponent (pit gate) #470
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Info on
UndercaveMapComponent:MapComponentTick
and why it needs patching:TriggerCollapseFX
does have an effect on simulation by spawning collapsed mountain roofFixing RNG is easy by just pushing/popping the state.
Fixing the collapsed mountain roof is more complex. Possible solutions:
TriggerCollapseFX
and call it in a deterministic way (used in this PR)Information about the patch:
Rand.MTBEventOccurs
always fail, making soTriggerCollapseFX
is never calledTriggerCollapseFX
in a deterministic way0
as both arguments to prevent additional effects from triggeringGen.HashCombineInt(Find.TickManager.TicksGame, __instance.map.uniqueID)
if we care about having a seed hereRemaining issues with
UndercaveMapComponent
/Pit Gate: