Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test-pyproject-toml #47

Closed
wants to merge 15 commits into from
Closed

test-pyproject-toml #47

wants to merge 15 commits into from

Conversation

hadijannat
Copy link

No description provided.

@hadijannat hadijannat force-pushed the test-pyproject-toml branch from d03eaff to 72d9ff9 Compare July 5, 2024 08:00
Copy link

@s-heppner s-heppner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's my review:

pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
@s-heppner
Copy link

And then furthermore, this PR should probably point at eclipse-basyx/basyx-python-sdk/main, rather than our fork's main

@hadijannat
Copy link
Author

hadijannat commented Jul 5, 2024

I think I don't have the permission to push on the main repo, so I created a Fork :)

- Remove reference to aas-compliance-check from pyproject.toml
- Add newline at end of pyproject.toml
- Remove entry point for aas-compliance-check from setup.py
pyproject.toml Outdated
@@ -4,10 +4,10 @@ build-backend = "setuptools.build_meta"

[project]
name = "basyx-python-sdk"
version = "0.1.0" # Replace with your actual version
version = "1.0.0" # actual version

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment is not a particularly good one, as it is obvious that version equals the version

pyproject.toml Outdated
description = "The Eclipse BaSyx Python SDK, an implementation of the Asset Administration Shell for Industry 4.0 systems"
authors = [
{name = "The Eclipse BaSyx Authors", email = "[email protected]"} # Replace with a real email
{name = "The Eclipse BaSyx Authors", email = "[email protected]"} # actual authors

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you cannot leave out the E-Mail field, I'd use [email protected].
Same thing as above about the comment.

requirements.txt Outdated
Comment on lines 6 to 11
urllib3>=1.26,<2.0
lxml-stubs~=0.5.1

jsonschema~=4.7
types-python-dateutil
lxml-stubs~=0.5.1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still not sure about the dependencies, but ignore, if you're not done with them.

"aas-compliance-check=basyx.aas.compliance_tool.cli:main"
]
},

)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No new line at the end of the file

@rwth-iat rwth-iat deleted a comment from hadijannat Jul 5, 2024
@hadijannat hadijannat force-pushed the test-pyproject-toml branch from 22fdeb4 to b61e183 Compare July 19, 2024 20:46
@hadijannat
Copy link
Author

hadijannat commented Jul 24, 2024

For further development, see: #51

@hadijannat hadijannat closed this Jul 24, 2024
@s-heppner s-heppner deleted the test-pyproject-toml branch July 24, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants