Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter level when getting window by location #1268

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

decodism
Copy link
Contributor

@rxhanson rxhanson merged commit 7e90241 into rxhanson:master Sep 21, 2023
1 check passed
@rxhanson
Copy link
Owner

Thanks! This is a good way to handle this that I didn't really think through initially.

@rxhanson
Copy link
Owner

I'm going to push out a Rectangle Pro beta with your change, since there are more users reporting there, and will follow up with a Rectangle release depending on the response. Even if there are still some apps that cause issues, this is definitely a step in the right direction.

@decodism
Copy link
Contributor Author

I think a more effective fix would be possible with window tags, but that requires private APIs.

@decodism decodism deleted the master-2 branch September 22, 2023 12:33
@rxhanson
Copy link
Owner

rxhanson commented Sep 26, 2023

I've been considering reducing that window level threshold from 1000 to 23. This way it will ignore the Notification Center (level 23). Do you know of any windows above level 23 that would be valid for drag to screen edge snapping?

@decodism
Copy link
Contributor Author

I'm not sure which level threshold is "safe".

@rxhanson
Copy link
Owner

@decodism, thanks! I think this might be the best option I have at the moment so I'm going to go with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snap Area doesn't work since update to Version 3.0.9 (150)
2 participants