Fix default skip forward/backward controls in CommandCenter #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Yeah I saw that swift PR, was hoping to test it out soon! |
|
Hi @DGempler I'm really sorry for the delay. The Swift direction may be a lot more involved than originally thought, and I shouldn't delay iOS development any further. I have merged your PR now (finally!) and will try to get things moving again on the iOS development front. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing an issue introduced with #196
The control/command center always displays skip forward/backward controls now, by default.
skipForwardIntervalandskipBackwardIntervalare pointers to objects and therefore we need to access theirintegerValueproperty to have a valid comparison against 0.Tested to work with and without passed in fastForwardInterval & rewindInterval values.