Make revision attr mandatory & improve docs

ryanrasti · Sep 3, 2018 · 944d1b0 · 944d1b0
1 parent ea744d4
commit 944d1b0
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/README.md b/README.md
@@ -79,14 +79,16 @@ nixpkgs_git_repository(name, revision, sha256)
       <td>
         <p><code>String; optional</code></p>
         <p>The URI of the remote Git repository. This must be a HTTP
-           URL. There is currently no support for authentication.</p>
+           URL. There is currently no support for authentication.
+           Defaults to <a href="https://github.com/NixOS/nixpkgs">
+           upstream nixpkgs.</a></p>
       </td>
     </tr>
     <tr>
       <td><code>sha256</code></td>
       <td>
         <p><code>String; optional</code></p>
-        <p>The SHA256 used to verify the integrity of the repository</p>
+        <p>The SHA256 used to verify the integrity of the repository.</p>
       </td>
     </tr>
   </tbody>

diff --git a/nixpkgs/nixpkgs.bzl b/nixpkgs/nixpkgs.bzl
@@ -13,7 +13,7 @@ def _nixpkgs_git_repository_impl(ctx):
 nixpkgs_git_repository = repository_rule(
   implementation = _nixpkgs_git_repository_impl,
   attrs = {
-    "revision": attr.string(),
+    "revision": attr.string(mandatory = True),
     "remote": attr.string(default = "https://github.com/NixOS/nixpkgs"),
     "sha256": attr.string(),
   },