Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the ability to auto dismiss flash messages #17

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Emerson
Copy link
Collaborator

@Emerson Emerson commented Jul 14, 2014

This pull request adds the auto dismissing feature outlined in issue #16. It's a little rough around the edges, so I totally understand if we don't want to merge it in yet, but I wanted to get it on the radar.

I'm using this code in my app and everything has been smooth so far, but the fact that I was not able to write a proper test for this makes me sad :rage1: . I also have a hunch that some of the code could be written in a cleaner way.

@jvenator
Copy link

Any reason why this was never merged in? Certainly useful, and is a relatively standard feature for flash messages.

@Emerson
Copy link
Collaborator Author

Emerson commented Jan 19, 2015

I think the lack of tests was the main reason? As mentioned above, I'm using it in production and haven't had any issues - but having proper tests would give us peace of mind.

Looking at the Files changed tab, I'm also seeing area's where things could be done cleaner and more modularly...

@jvenator
Copy link

@Emerson Thanks for the update.

@Emerson
Copy link
Collaborator Author

Emerson commented Feb 15, 2015

@jvenator - just a heads up that I recently published an Ember-CLI flash message addon. It has a very similar API to this library and includes the auto dismiss functionality. You can see a demo of it here and the main repo here. Still early days, but would love some feedback!

@jvenator
Copy link

@Emerson I'll check it out, although we ended up going with ember-notify for our main app. Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants