Merge pull request #53 from ryanwelcher/fix/exclude-current-error

Remove useState hook for the excluded current post that was causing Maximum update depth exceeded errors.
ryanwelcher · Apr 29, 2024 · bc4104d · bc4104d
2 parents fe71cd9 + 0c09a36
commit bc4104d
Showing 1 changed file with 3 additions and 7 deletions.
diff --git a/src/components/post-include-controls.js b/src/components/post-include-controls.js
@@ -24,8 +24,6 @@ export const PostIncludeControls = ( { attributes, setAttributes } ) => {
 	const [ searchArg, setSearchArg ] = useState( '' );
 	const [ multiplePostsState, setMultiplePostsState ] =
 		useState( multiplePosts );
-	const [ excludeCurrentState, setExcludeCurrentState ] =
-		useState( excludeCurrent );
 
 	const posts = useSelect(
 		( select ) => {
@@ -58,8 +56,7 @@ export const PostIncludeControls = ( { attributes, setAttributes } ) => {
 	useEffect( () => {
 		if (
 			JSON.stringify( multiplePosts ) !==
-				JSON.stringify( multiplePostsState ) ||
-			excludeCurrent !== excludeCurrentState
+			JSON.stringify( multiplePostsState )
 		) {
 			setAttributes( {
 				query: {
@@ -68,10 +65,9 @@ export const PostIncludeControls = ( { attributes, setAttributes } ) => {
 				},
 			} );
 			setMultiplePostsState( multiplePosts );
-			setExcludeCurrentState( excludeCurrent );
 		}
-	}, [ multiplePosts, excludeCurrent ] );
-	
+	}, [ multiplePosts ] );
+
 	/**
 	 * Retrieves the ID of a post based on its title.
 	 *