Add CodeQL query to detect redundant assignments

Signed-off-by: Richard Yao <[email protected]>

.github/codeql-cpp.yml

@@ -0,0 +1,5 @@
+name: "Custom CodeQL Analysis"
+
+queries:
+  - uses: ./.github/codeql/custom-queries/cpp/redundantAssignment.ql
+  - uses: ./.github/codeql/openzfs-code-scanning.qls

.github/codeql-python.yml

@@ -0,0 +1,4 @@
+name: "Custom CodeQL Analysis"
+
+paths-ignore:
+  - tests

.github/codeql/custom-queries/cpp/qlpack.yml

@@ -0,0 +1,4 @@
+name: openzfs-cpp-queries
+version: 0.0.0
+libraryPathDependencies: codeql-cpp
+suites: openzfs-cpp-suite

.github/codeql/custom-queries/cpp/redundantAssignment.c

@@ -0,0 +1,8 @@
+int
+main(void) {
+	int a = 0;
+	int b = a;
+	int c = 1;
+	a = b;
+	return (a*b*c);
+}

.github/codeql/custom-queries/cpp/redundantAssignment.ql

@@ -0,0 +1,26 @@
+/**
+ * @name Redundant assignment detection
+ * @description Detects redundant assignments like 'a = b;' followed by 'b = a;' without any modification in between.
+ * @kind problem
+ * @id cpp/redundant-assignment
+ */
+
+import cpp
+
+from Assignment firstAssign, Assignment secondAssign
+where
+  // The first assignment is from 'a' to 'b'
+  firstAssign.getLValue().(VariableAccess).getTarget() = secondAssign.getRValue().(VariableAccess).getTarget() and
+  firstAssign.getRValue().(VariableAccess).getTarget() = secondAssign.getLValue().(VariableAccess).getTarget() and
+  // Ensure 'a' and 'b' are not modified in between these assignments
+  not exists(Assignment anyAssign |
+    anyAssign.getEnclosingFunction() = firstAssign.getEnclosingFunction() and
+    anyAssign.getLocation().getFile() = firstAssign.getLocation().getFile() and
+    anyAssign.getLocation().getStartLine() > firstAssign.getLocation().getStartLine() and
+    anyAssign.getLocation().getStartLine() < secondAssign.getLocation().getStartLine() and
+    (
+      anyAssign.getLValue().(VariableAccess).getTarget() = firstAssign.getLValue().(VariableAccess).getTarget() or
+      anyAssign.getLValue().(VariableAccess).getTarget() = firstAssign.getRValue().(VariableAccess).getTarget()
+    )
+  )
+select secondAssign, "This assignment is redundant."

.github/codeql/openzfs-code-scanning.qls

@@ -0,0 +1,3 @@
+# Reusing existing QL Pack
+- import: codeql-suites/cpp-code-scanning.qls
+  from: codeql-cpp

.github/workflows/codeql.yml

@@ -29,6 +29,7 @@ jobs:
     - name: Initialize CodeQL
       uses: github/codeql-action/init@v2
       with:
+        config-file: .github/codeql-${{ matrix.language }}.yml
         languages: ${{ matrix.language }}
 
     - name: Autobuild