Skip to content

Commit

Permalink
FIX: #265
Browse files Browse the repository at this point in the history
  • Loading branch information
rydmike committed Dec 1, 2024
1 parent fa03008 commit 9a31397
Show file tree
Hide file tree
Showing 12 changed files with 32 additions and 19 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/deploy_playground.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
name: Deploy_Playground
on:
push:
branches: [master]
branches: [none]
paths-ignore:
- "**.md"
jobs:
Expand Down
14 changes: 14 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,20 @@

All changes to the **FlexColorScheme** (FCS) package are documented here.

## 8.0.2

**Dec 1, 2024**

### Package

**FIX**

* Changelog for version 8.0.0 says and intended this:
> "The `FlexSubThemesData` property `inputDecoratorIsFilled` now default to `false` when undefined, like Flutter SDK does.
> Set it to `true` to get the same style it had with previous undefined value."
Due to a bug, this was not the case. This release fixes the bug and the property now defaults to `false` when undefined, as intended and documented in version 8.0.0 changelog. FIX: https://github.com/rydmike/flex_color_scheme/issues/265

## 8.0.1

**Nov 13, 2024**
Expand Down
3 changes: 3 additions & 0 deletions example/.vscode/settings.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"dart.flutterSdkPath": ".fvm/versions/stable"
}
4 changes: 2 additions & 2 deletions example/lib/shared/const/app.dart
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@ sealed class App {
// build numbers.
static const String versionMajor = '8';
static const String versionMinor = '0';
static const String versionPatch = '1';
static const String versionBuild = '06';
static const String versionPatch = '2';
static const String versionBuild = '01';
static const String versionFull = '$versionMajor.$versionMinor.$versionPatch'
'\nBuild-$versionBuild';
static const String version = '$versionMajor.$versionMinor.$versionPatch';
Expand Down
2 changes: 1 addition & 1 deletion example/macos/Podfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -33,4 +33,4 @@ SPEC CHECKSUMS:

PODFILE CHECKSUM: 236401fc2c932af29a9fcf0e97baeeb2d750d367

COCOAPODS: 1.15.2
COCOAPODS: 1.16.2
2 changes: 1 addition & 1 deletion example/pubspec.lock
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ packages:
path: ".."
relative: true
source: path
version: "8.0.1"
version: "8.0.2"
flex_seed_scheme:
dependency: "direct main"
description:
Expand Down
2 changes: 1 addition & 1 deletion example/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: flex_color_scheme_example
description: Examples that demonstrate how to use the FlexColorScheme package.
version: 8.0.1
version: 8.0.2
publish_to: 'none'
environment:
sdk: '>=3.0.0 <4.0.0'
Expand Down
2 changes: 1 addition & 1 deletion lib/src/flex_color_scheme.dart
Original file line number Diff line number Diff line change
Expand Up @@ -7409,7 +7409,7 @@ class FlexColorScheme with Diagnosticable {
// Kept for backwards defaults compatibility. Only used when not
// using opinionated component sub-themes in M2 mode.
: InputDecorationTheme(
filled: subTheme.inputDecoratorIsFilled,
filled: subTheme.inputDecoratorIsFilled ?? true,
fillColor: isDark
? colorScheme.primary.withAlpha(0x0F) // 6%
: colorScheme.primary.withAlpha(0x09), // 3.5%
Expand Down
6 changes: 3 additions & 3 deletions lib/src/flex_sub_themes_data.dart
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ class FlexSubThemesData with Diagnosticable {
this.inputDecoratorSchemeColor,
this.inputDecoratorContentPadding,
this.inputDecoratorIsDense,
this.inputDecoratorIsFilled = true,
this.inputDecoratorIsFilled,
this.inputDecoratorFillColor,
this.inputDecoratorBackgroundAlpha,
this.inputDecoratorBorderSchemeColor,
Expand Down Expand Up @@ -1835,8 +1835,8 @@ class FlexSubThemesData with Diagnosticable {
/// on sub-themes. Giving an opportunity to make the past always filled input
/// decorator even less opinionated.
///
/// Defaults to false.
final bool inputDecoratorIsFilled;
/// Defaults to false, if not defined.
final bool? inputDecoratorIsFilled;

/// Determines the color of the filled [InputDecorator].
///
Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: flex_color_scheme
description: A Flutter package to use and make beautiful Material design based themes.
version: 8.0.1
version: 8.0.2
homepage: https://docs.flexcolorscheme.com
repository: https://github.com/rydmike/flex_color_scheme
issue_tracker: https://github.com/rydmike/flex_color_scheme/issues
Expand Down
2 changes: 1 addition & 1 deletion test/flex_color_scheme_test.dart

Large diffs are not rendered by default.

10 changes: 3 additions & 7 deletions test/flex_sub_themes_data_test.dart

Large diffs are not rendered by default.

0 comments on commit 9a31397

Please sign in to comment.