Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo #128

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Fix typo #128

merged 1 commit into from
Apr 3, 2024

Conversation

razzeee
Copy link
Contributor

@razzeee razzeee commented Apr 3, 2024

I'm unsure, if three primary colors is supported at all, but the typo meant, these were not picked up.

I'm unsure, if three primary colors is supported at all, but the typo meant, these were not picked up.
@ryonakano
Copy link
Owner

Thank you for pointing out the typo!

I'm unsure, if three primary colors is supported at all

The type="primary" seems to be required according to the doc:

A color tag must have a type attribute which denotes the color type. The color type may currently only be primary.

So it should be fine, although it looks weird.

@ryonakano ryonakano merged commit 7aa85f0 into ryonakano:main Apr 3, 2024
3 checks passed
@razzeee
Copy link
Contributor Author

razzeee commented Apr 3, 2024

I did not mean the primary part :)

As we asume, that there is only light and dark, and no third state, the fallback seems weird (the one without scheme)

@ryonakano
Copy link
Owner

Ah got it. That would be useless, maybe we can remove it 😅

@razzeee
Copy link
Contributor Author

razzeee commented Apr 3, 2024

We totally can, at least on flathub I couldn't find another app that does something similar. Still, I was wondering, what you we're trying to do.

@ryonakano
Copy link
Owner

I don't remember what I meant here, but it looks like elementary AppCenter, where I publish this app to, looks like to use this line instead of lines with scheme:

https://github.com/elementary/appcenter/blob/f8db5192b69da0846fa9e62f789e15e0dbf0cf29/src/Core/Package.vala#L826

I'm not sure why AppCenter refer to the lines with scheme though.

@razzeee
Copy link
Contributor Author

razzeee commented Apr 3, 2024

It should fallback to that, in the abscence of either dark/light from my understanding of the spec - but the code looks weird indeed (from very far away)

Might just be too old.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants