Skip to content

Commit

Permalink
Fix a bug that modifier note didn't have effect when played with voic…
Browse files Browse the repository at this point in the history
…ed notes at the same time
  • Loading branch information
ryukau committed Oct 11, 2024
1 parent 8f2ec18 commit 354819a
Show file tree
Hide file tree
Showing 5 changed files with 49 additions and 22 deletions.
4 changes: 2 additions & 2 deletions GlitchSprinkler/source/dsp/dspcore.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -329,12 +329,12 @@ void DSPCore::process(const size_t length, float *out0, float *out1)
std::array<double, 2> frame{};
for (size_t i = 0; i < length; ++i) {
processModifierNote(i);
processMidiNote(i);

pitchModifier = activeModifier.empty()
? double(1)
: double(activeModifier.back().noteNumber + activeModifier.back().cent);

processMidiNote(i);

frame.fill({});

for (auto &vc : voices) {
Expand Down
10 changes: 5 additions & 5 deletions GlitchSprinkler/source/version.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// (c) 2018, Steinberg Media Technologies GmbH, All Rights Reserved
//
// Modified by:
// (c) 2023 Takamitsu Endo
// (c) 2024 Takamitsu Endo
//
// This file is part of GlitchSprinkler.
//
Expand All @@ -29,11 +29,11 @@
#define SUB_VERSION_STR "1"
#define SUB_VERSION_INT 1

#define RELEASE_NUMBER_STR "0"
#define RELEASE_NUMBER_INT 0
#define RELEASE_NUMBER_STR "1"
#define RELEASE_NUMBER_INT 1

#define BUILD_NUMBER_STR "0"
#define BUILD_NUMBER_INT 0
#define BUILD_NUMBER_STR "1"
#define BUILD_NUMBER_INT 1

#define FULL_VERSION_STR \
MAJOR_VERSION_STR "." SUB_VERSION_STR "." RELEASE_NUMBER_STR "." BUILD_NUMBER_STR
Expand Down
11 changes: 10 additions & 1 deletion docs/manual/GlitchSprinkler/GlitchSprinkler.json
Original file line number Diff line number Diff line change
@@ -1,13 +1,22 @@
{
"GlitchSprinkler": {
"latest_version": "0.0.1",
"latest_version": "0.1.1",
"urls": {
"plugin_url": [
"https://github.com/ryukau/VSTPlugins/releases/download/UhhyouPlugins0.63.0/GlitchSprinkler_0.1.1.zip",
"https://github.com/ryukau/VSTPlugins/releases/download/UhhyouPlugins0.62.0/GlitchSprinkler_0.0.1.zip"
],
"preset_url": []
},
"changelog": {
"0.1.1": {
"en": [
"Fixed a bug that first modifier note (MIDI ch. 16) didn't have effect when played at the same time as a voiced note."
],
"ja": [
"MIDI チャンネル 16 のノートオンと、他のチャンネルのノートオンが同じタイミングで演奏されたとき、音程の変化が起こらなかったバグを修正。"
]
},
"0.0.1": { "en": ["Initial release."], "ja": ["初期リリース。"] }
}
}
Expand Down
23 changes: 16 additions & 7 deletions docs/manual/GlitchSprinkler/GlitchSprinkler_en.html
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<meta charset="utf-8" />
<meta name="generator" content="pandoc" />
<meta name="viewport" content="width=device-width, initial-scale=1.0, user-scalable=yes" />
<meta name="dcterms.date" content="2024-09-28" />
<meta name="dcterms.date" content="2024-10-11" />
<title>GlitchSprinkler_en – Uhhyou Plugins</title>
<link rel="icon" type="image/svg+xml" href="../../img/favicon/favicon.svg">
<link rel="icon" type="image/png" href="../../img/favicon/favicon.svgindex-relative-path=../../index.html">
Expand Down Expand Up @@ -285,7 +285,7 @@
<header>
<p><a href="../../index.html">Back to Index</a></p>
<p>
Update: 2024-09-28
Update: 2024-10-11
</p>
<details>
<summary translate="yes">Table of Contents</summary>
Expand Down Expand Up @@ -363,15 +363,15 @@ <h1 id="glitchsprinkler"><a href="#glitchsprinkler"
especially at higher notes, which makes a unique texture.</p>
<ul>
<li><a
href="https://github.com/ryukau/VSTPlugins/releases/download/UhhyouPlugins0.62.0/GlitchSprinkler_0.0.1.zip">Download
GlitchSprinkler 0.0.1 <code>full</code> - VST 3 (github.com)</a> <img
href="https://github.com/ryukau/VSTPlugins/releases/download/UhhyouPlugins0.63.0/GlitchSprinkler_0.1.1.zip">Download
GlitchSprinkler 0.1.1 <code>full</code> - VST 3 (github.com)</a> <img
src="img/VST_Compatible_Logo_Steinberg_negative.svg"
alt="VST compatible logo."
width="30px"
style="display: inline-block; vertical-align: middle;"></li>
<li><a
href="https://github.com/ryukau/VSTPlugins/releases/download/UhhyouPlugins0.62.0/GlitchSprinkler_0.0.1_macOS.zip">Download
GlitchSprinkler 0.0.1 <code>macOS</code> - VST 3 (github.com)</a> <img
href="https://github.com/ryukau/VSTPlugins/releases/download/UhhyouPlugins0.63.0/GlitchSprinkler_0.1.1_macOS.zip">Download
GlitchSprinkler 0.1.1 <code>macOS</code> - VST 3 (github.com)</a> <img
src="img/VST_Compatible_Logo_Steinberg_negative.svg"
alt="VST compatible logo."
width="30px"
Expand Down Expand Up @@ -1117,14 +1117,23 @@ <h3 id="unison"><a href="#unison" class="header-anchor"
<h2 id="change-log"><a href="#change-log" class="header-anchor"
aria-hidden="true">Change Log</a></h2>
<ul>
<li>0.1.1
<ul>
<li>Fixed a bug that first modifier note (MIDI ch. 16) didn’t have
effect when played at the same time as a voiced note.</li>
</ul></li>
<li>0.0.1
<ul>
<li>Initial release.</li>
</ul></li>
</ul>
<h2 id="old-versions"><a href="#old-versions" class="header-anchor"
aria-hidden="true">Old Versions</a></h2>
<p>N/A.</p>
<ul>
<li><a
href="https://github.com/ryukau/VSTPlugins/releases/download/UhhyouPlugins0.62.0/GlitchSprinkler_0.0.1.zip">GlitchSprinkler
0.0.1 - VST 3 (github.com)</a></li>
</ul>
<h2 id="license"><a href="#license" class="header-anchor"
aria-hidden="true">License</a></h2>
<p>GlitchSprinkler is licensed under GPLv3. Complete licenses are
Expand Down
23 changes: 16 additions & 7 deletions docs/manual/GlitchSprinkler/GlitchSprinkler_ja.html
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<meta charset="utf-8" />
<meta name="generator" content="pandoc" />
<meta name="viewport" content="width=device-width, initial-scale=1.0, user-scalable=yes" />
<meta name="dcterms.date" content="2024-09-28" />
<meta name="dcterms.date" content="2024-10-11" />
<title>GlitchSprinkler_ja – Uhhyou Plugins</title>
<link rel="icon" type="image/svg+xml" href="../../img/favicon/favicon.svg">
<link rel="icon" type="image/png" href="../../img/favicon/favicon.svgindex-relative-path=../../index.html">
Expand Down Expand Up @@ -285,7 +285,7 @@
<header>
<p><a href="../../index.html">Back to Index</a></p>
<p>
Update: 2024-09-28
Update: 2024-10-11
</p>
<details>
<summary translate="yes">Table of Contents</summary>
Expand Down Expand Up @@ -361,15 +361,15 @@ <h1 id="glitchsprinkler"><a href="#glitchsprinkler"
は速いアルペジオに特化したシンセサイザです。オシレータの周期を整数のサンプル数のみとすることで安価にアンチエイリアシングを行っています。このアンチエイリアシングの副作用により、特に音程が高いときにピッチがずれて独特の音律が現れます。</p>
<ul>
<li><a
href="https://github.com/ryukau/VSTPlugins/releases/download/UhhyouPlugins0.62.0/GlitchSprinkler_0.0.1.zip">GlitchSprinkler
0.0.1 <code>full</code> - VST 3 をダウンロード (github.com)</a> <img
href="https://github.com/ryukau/VSTPlugins/releases/download/UhhyouPlugins0.63.0/GlitchSprinkler_0.1.1.zip">GlitchSprinkler
0.1.1 <code>full</code> - VST 3 をダウンロード (github.com)</a> <img
src="img/VST_Compatible_Logo_Steinberg_negative.svg"
alt="VST compatible logo."
width="30px"
style="display: inline-block; vertical-align: middle;"></li>
<li><a
href="https://github.com/ryukau/VSTPlugins/releases/download/UhhyouPlugins0.62.0/GlitchSprinkler_0.0.1_macOS.zip">GlitchSprinkler
0.0.1 <code>macOS</code> - VST 3 をダウンロード (github.com)</a> <img
href="https://github.com/ryukau/VSTPlugins/releases/download/UhhyouPlugins0.63.0/GlitchSprinkler_0.1.1_macOS.zip">GlitchSprinkler
0.1.1 <code>macOS</code> - VST 3 をダウンロード (github.com)</a> <img
src="img/VST_Compatible_Logo_Steinberg_negative.svg"
alt="VST compatible logo."
width="30px"
Expand Down Expand Up @@ -1095,14 +1095,23 @@ <h3 id="unison"><a href="#unison" class="header-anchor"
<h2 id="チェンジログ"><a href="#チェンジログ" class="header-anchor"
aria-hidden="true">チェンジログ</a></h2>
<ul>
<li>0.1.1
<ul>
<li>MIDI チャンネル 16
のノートオンと、他のチャンネルのノートオンが同じタイミングで演奏されたとき、音程の変化が起こらなかったバグを修正。</li>
</ul></li>
<li>0.0.1
<ul>
<li>初期リリース。</li>
</ul></li>
</ul>
<h2 id="旧バージョン"><a href="#旧バージョン" class="header-anchor"
aria-hidden="true">旧バージョン</a></h2>
<p>旧バージョンはありません。</p>
<ul>
<li><a
href="https://github.com/ryukau/VSTPlugins/releases/download/UhhyouPlugins0.62.0/GlitchSprinkler_0.0.1.zip">GlitchSprinkler
0.0.1 - VST 3 (github.com)</a></li>
</ul>
<h2 id="ライセンス"><a href="#ライセンス" class="header-anchor"
aria-hidden="true">ライセンス</a></h2>
<p>GlitchSprinkler のライセンスは GPLv3 です。 GPLv3
Expand Down

0 comments on commit 354819a

Please sign in to comment.