Update inline TODOs. Remove some dead code.

ryukzak · Mar 7, 2022 · 6a65727 · 6a65727
1 parent 972d9f7
commit 6a65727
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 22 deletions.
diff --git a/src/NITTA/Model/ProcessIntegrity.hs b/src/NITTA/Model/ProcessIntegrity.hs
@@ -53,7 +53,7 @@ checkVerticalRelations f dom codom errmsg =
             )
             $ M.keys dom
 
--- TODO: fix errors in process units
+-- TODO: #205 Divider: missing vertical relation between Do instruction and Endpoint
 skipIntegrityErrors = ["instruction not related to endpoint: Instruction: Do"]
 
 collectChecks checks = case lefts checks of
@@ -77,12 +77,6 @@ down2up pu = relationsMap $ mapMaybe get $ relations $ process pu
         get Vertical{vUp, vDown} = Just (vDown, vUp)
         get _ = Nothing
 
-pid2cad pu = M.fromList $ mapMaybe get $ steps $ process pu
-    where
-        get s@Step{pID}
-            | Just cad <- getCad s = Just (pID, cad)
-            | otherwise = Nothing
-
 pid2intermediate pu = M.fromList $ mapMaybe get $ steps $ process pu
     where
         get s@Step{pID}

diff --git a/test/NITTA/Model/ProcessorUnits/Broken/Tests.hs b/test/NITTA/Model/ProcessorUnits/Broken/Tests.hs
@@ -155,21 +155,6 @@ tests =
             , expectFail $ puCoSimTestCase "puCoSimTestCase lostEndpointInVerticalRelation" u{lostEndpointInVerticalRelation = True} [("a", 42)] [brokenBuffer "a" ["b"]]
             , expectFail $ puCoSimTestCase "puCoSimTestCase lostInstructionInVerticalRelation" u{lostInstructionInVerticalRelation = True} [("a", 42)] [brokenBuffer "a" ["b"]]
             ]
-            -- , testGroup
-            --     "broken relations integrity check negative coSim"
-            --     -- nittaCoSimTestCase has isLeaf and isComplete, but Relation alright because of CAD
-            --     -- TODO: below cases ignores lost because of CAD steps and failed because simulation
-            --     [ expectFail $ nittaCoSimTestCase "nittaCoSimTestCase lost Endpoints" (maBroken u{lostEndpointRelation = True}) alg
-            --     , expectFail $ nittaCoSimTestCase "nittaCoSimTestCase lost Instruction" (maBroken u{lostInstructionRelation = True}) alg
-            --     , expectFail $ typedLuaTestCase (maBroken def{lostEndpointRelation = True}) pInt "typedLuaTestCase lost Endpoints" lua
-            --     , expectFail $ typedLuaTestCase (maBroken def{lostInstructionRelation = True}) pInt "typedLuaTestCase lost Instruction" lua
-            --     ]
-            -- testGroup
-            --   "broken relations integrity check negative fails"
-            --   -- TODO: try lua function without break loop
-            --   [ expectFail $ nittaCoSimTestCase "nittaCoSimTestCase lost Function" (maBroken u{lostFunctionRelation = True}) alg
-            --   , expectFail $ typedLuaTestCase (maBroken def{lostFunctionRelation = True}) pInt "typedLuaTestCase lost Function" lua
-            --   ]
         ]
     where
         u = def :: Broken T.Text Int Int