Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

72 Integrity check for horizontal relations (CADStep relations) #107

Merged
merged 3 commits into from
Apr 12, 2021

Conversation

ryukzak
Copy link
Owner

@ryukzak ryukzak commented Apr 7, 2021

#72
CAD steps used for:

  • store information about binding;
  • store information about refactoring.

But in practice, only Fram work with it and work in a wrong way (it is incorrect to call relations between a binding and a refactoring vertical). So decide to introduce horizontal relation type in this branch and request the integrity check for it.

Rules:

  • All function steps should be related to CADStep by binding vertically.
  • All CADSteps should be related to:
    • function step vertically
    • or another CADStep horizontally (direction doesn't matter).

E.g.,

  • Bind Loop -> Bind LoopBegin (horizontal)
  • Bind Loop -> Bind LoopEnd (horizontal)
  • Bind LoopBegin -> FStep LoopBegin (Vertical)
  • Bind LoopEnd -> FStep LoopBegin (Vertical)

Before merge:

@ryukzak ryukzak added bug Something isn't working hs Haskell labels Apr 7, 2021
@co0ll3r co0ll3r merged commit 6d5444b into 72-integrity-check Apr 12, 2021
@ryukzak ryukzak deleted the 72-integrity-check-horizontal-relations branch April 14, 2021 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hs Haskell
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants