replace toml to yaml #276
replace toml to yaml #276
Conversation
examples/microarch.yml
Outdated
| networks: | ||
| - name: net1 | ||
| pus: | ||
| - type: SPI |
There was a problem hiding this comment.
Maybe we can use name as key here? Do you see any disadvantages of this approuch?
The same for the network
| isSlave: true | ||
| bufferSize: 6 | ||
| bounceFilter: 0 | ||
| protos: |
There was a problem hiding this comment.
Let move it to the top level as puLibrary.
There was a problem hiding this comment.
Is is about all PUs, which nitta can allocate automatically. Current -- in network. Should be -- on the top level & network.
examples/microarch.yml
Outdated
| name: fram{x} # If you want a PU can be allocated only once, remove {x} from the PU name. | ||
| size: 32 | ||
| - type: Shift | ||
| name: shift{x} |
There was a problem hiding this comment.
Do you know what this special syntax means?
examples/microarch.yml
Outdated
| isInt: true | ||
| - type: Divider | ||
| name: div{x} | ||
| mock: true |
There was a problem hiding this comment.
Will be nice to make possible to set this attr globally.
There was a problem hiding this comment.
Mock -- attr used for logic simulation via icarus verilog for complex PU, like divider.
Usually, we don't need to specify it for PUs independently, so it will be nice to move it on the top level.
| newtype MicroarchitectureConf = MicroarchitectureConf | ||
| { networks :: [NetworkConf] | ||
| data MicroarchitectureConf = MicroarchitectureConf | ||
| { type' :: T.Text |
There was a problem hiding this comment.
Better to name it like valueType. ' can be confusing here.
In the future, it is possible to make type specific for each network.
| { networks :: [NetworkConf] | ||
| data MicroarchitectureConf = MicroarchitectureConf | ||
| { type' :: T.Text | ||
| , ioSync' :: IOSynchronization |
| Nothing -> return Nothing | ||
| Just path -> Just . getToml <$> T.readFile path | ||
| Just path -> Just <$> parseConfig path |
There was a problem hiding this comment.
Something like parseConfig <$> path should work?
There was a problem hiding this comment.
parseConfig is a FilePath -> IO MicroarchitectureConf type
path is a FilePath type
<$> is a (a -> b) -> f a -> f b type
The result must be type of IO Maybe MicroarchitectureConf, so Just <$> parseConfig pathdoesn't seem to be able to be simplified.
| } | ||
| deriving (Generic, Show) | ||
|
|
||
| instance FromJSON MicroarchitectureConf | ||
| instance FromJSON MicroarchitectureConf where |
There was a problem hiding this comment.
Is it possible to do it via Generic?
There was a problem hiding this comment.
Didn't work out ¯\_(ツ)_/¯
There was a problem hiding this comment.
Strange. Maybe because you need to use HashMap instead of Map.
| type' <- v .: "type" | ||
| ioSync' <- v .: "ioSync" | ||
| networks <- v .: "networks" | ||
| return MicroarchitectureConf{type' = type', ioSync' = ioSync', networks = networks} |
There was a problem hiding this comment.
| decodeFileThrow path :: IO MicroarchitectureConf | ||
|
|
||
| mkMicroarchitecture :: (Val v, Var x, ToJSON x) => MicroarchitectureConf -> BusNetwork T.Text x v Int | ||
| mkMicroarchitecture conf = |
examples/microarch.yml
Outdated
| mock: true | ||
| type: fx32.32 | ||
| ioSync: Sync | ||
| puLibrary: |
There was a problem hiding this comment.
Hmm. Here we have misunderstanding. The idea behind this: describe library of process unit to be allocated in separated place, with name "library" intead of "proto"
| } | ||
| deriving (Generic, Show) | ||
|
|
||
| instance FromJSON MicroarchitectureConf | ||
| instance FromJSON MicroarchitectureConf where |
There was a problem hiding this comment.
Strange. Maybe because you need to use HashMap instead of Map.
No description provided.