feat_integrity: added check integrity: functions should be present in… #98

co0ll3r · 2021-03-17T16:42:43Z

#72
Now it has two checks:

Search for a provided function in PU steps if function found then return its pID.
In PU relations takes every second pID of Relation and in steps checks that it Endpoint

Could you please check am I on a right way and tell about test fail?
WIP

fix error when CAD functions replaced with new variables
fix negative CAD tests where relations are not broken
fix small bugs in tests like Divider

test/NITTA/Model/ProcessorUnits/Tests/Utils.hs

ryukzak

You are on the right way.

test/NITTA/Model/ProcessorUnits/Tests/IntegrityCheck.hs

ryukzak

And negative tests with BrokenPU

src/NITTA/Model/IntegrityCheck.hs

ryukzak · 2021-03-31T21:00:06Z

src/NITTA/Model/IntegrityCheck.hs

+        checkRel (v1, v2) = case eps_ M.!? v1 of
+            Just _ | Just (InstructionStep _) <- ins_ M.!? v2 -> [True]
+            _ -> []
+     in and $ concatMap checkRel fromRelation


Why not like in checkIntermidiateToEndpointRelation?

src/NITTA/Synthesis/Explore.hs

ryukzak · 2021-03-31T21:02:29Z

src/NITTA/Model/ProcessorUnits/Fram.hs

                    when (null vsRemain) $ do
                        fPID <- scheduleFunction (0 ... sup epAt) function
                        establishVerticalRelations binds fPID
-                        establishVerticalRelations fPID (endpoints ++ endpoints')
+                        let low = eps ++ map pID (relatedEndpoints process_ $ variables function)
+                        establishVerticalRelations fPID low


I think these hlint suggestions are for me.

ryukzak

We close to the finish line here, but I found one general issue: we don't check relations with CADSteps.

So we need to end our work here and after rebase: #107

ryukzak · 2021-04-07T11:47:18Z

src/NITTA/Model/ProcessorUnits/Broken.hs

@@ -64,6 +64,8 @@ data Broken v x t = Broken
    , -- |lost source endpoint due synthesis
      lostEndpointSource :: Bool
    , wrongAttr :: Bool
+    , -- | lost vertical relation
+      lostVerticalRelation :: Bool


Split it into different types of error:

function without endpoints

endpoint without function

instruction without endpoint

endpoint without instruction

now all function variables covered by endpoints

etc

src/NITTA/Model/IntegrityCheck.hs

test/NITTA/Model/ProcessorUnits/Broken/Tests.hs

src/NITTA/Utils.hs

… steps, their variables should have Endpoints

…IntegrityCheck

…on for Broken epDecision

…ian mul)

…filter for PU

…ded templates for future typeclass.

… to be able to test integrity.

…ns, added detailed error (debug purpose). Rearranged tests in broken.

ryukzak · 2022-03-07T17:26:44Z

Work finished in: #202

ryukzak · 2022-03-07T17:27:00Z

Work finished here: #202

co0ll3r commented Mar 17, 2021

View reviewed changes

test/NITTA/Model/ProcessorUnits/Tests/Utils.hs Outdated Show resolved Hide resolved

co0ll3r requested a review from ryukzak March 17, 2021 16:56

ryukzak requested changes Mar 17, 2021

View reviewed changes

co0ll3r commented Mar 20, 2021

View reviewed changes

test/NITTA/Model/ProcessorUnits/Tests/IntegrityCheck.hs Outdated Show resolved Hide resolved

ryukzak reviewed Mar 23, 2021

View reviewed changes

test/NITTA/Model/ProcessorUnits/Tests/IntegrityCheck.hs Outdated Show resolved Hide resolved

test/NITTA/Model/ProcessorUnits/Tests/IntegrityCheck.hs Outdated Show resolved Hide resolved

co0ll3r commented Mar 25, 2021

View reviewed changes

test/NITTA/Model/ProcessorUnits/Tests/IntegrityCheck.hs Outdated Show resolved Hide resolved

ryukzak linked an issue Mar 30, 2021 that may be closed by this pull request

Add integrity check of a scheduled computational process into tests #72

Closed

co0ll3r requested a review from ryukzak March 31, 2021 02:13

ryukzak requested changes Mar 31, 2021

View reviewed changes

ryukzak requested changes Apr 7, 2021

View reviewed changes

co0ll3r and others added 20 commits May 21, 2021 20:21

feat_integrity: added check integrity: functions should be present in…

9aff95f

… steps, their variables should have Endpoints

Fix function - endpoint vertical relation in Fram.

8bb7693

feat_integrity: written functions to create maps

3355b95

feat_integrity: wrote intermidiate to endpoints function with Data.Map

d03f17b

feat_integrity: added endpoint to instruction check

821d612

feat_integrity: check to one more test

11d499e

refactor_integrity: changed to variables function

d2d6960

feat_integrity: rewritten check integrity method (not working)

3f7e4e9

feat_integrity: added IntegrityCheck file in src

25cbbe7

feat_integrity: fixed endpoint map generation

808c0de

feat_integrity: added isEndpoint method to Utils

6e3c713

feat_integrity: change using to internal integrity test, cleaning in …

ade37fa

…IntegrityCheck

feat_integrity: added function to intermediate relation check

5973f50

feat_integrity: added check endpoints to instructions

61a4376

fix_integrity: added IntegrityCheck to cabal

7cfb6cc

refactor_integrity: renamed functions

af9bf24

refactor_integrity: fixed variable names

db99ccc

fix_integrity: fixed two same keys bug

e695be7

feat_integrity: added broken test prototype

c33d826

fix_integrity: removed pid and fixed wrong functions

4d58d75

co0ll3r and others added 17 commits May 21, 2021 20:29

feat_integrity: updated Utils API

f6bd3fe

feat_integrity: added prototype for vertical CAD function check

00d70f3

fix_integrity: reworked get.*Map functions, returned old implementati…

af3f88a

…on for Broken epDecision

Make data Relations more explicit (require for UI use)

7d8144c

trying to extract variable from Transport (Bus.hs)

e7ad096

feat_integrity: replaced transport to function relations (with cartes…

8568583

…ian mul)

feat_integrity: test with Transport extraction

31fab6c

integrity: added Eq to make reversed Relation equal. Added transport …

7b59746

…filter for PU

feat_integrity: prototype (simple) for check Transport to Function

9df0e11

fix_integrity: refactored most functions, fixed bug in Eq of Relation

c801e29

feat_edsl: returned default deriving Relation

3c8e583

fix_edsl: refactored CAD tests, now it not fails

c794ef4

fix_edsl: refactor before merge to original branch

0458525

fix_integrity: fixed merge error

1636140

refactor_edsl: added error print when element in not found in map. Ad…

bef5a11

…ded templates for future typeclass.

refactor_integrity: added implementation to ProcessConsistent typeclass.

0ce1c3c

refactor_integrity: commented negative tests. Modified existing tests…

02bf39c

… to be able to test integrity.

co0ll3r force-pushed the 72-integrity-check branch from d537fc2 to 02bf39c Compare May 23, 2021 17:53

co0ll3r added 5 commits May 30, 2021 00:08

feat_integrity: added assertConsistency to DSL

63a7eaa

fix_integrity: removed checkIntegrity, replaced order of some functio…

a062f69

…ns, added detailed error (debug purpose). Rearranged tests in broken.

fix_edsl: removed ProcessConsistent instance for BusNetwork

3cabade

fix_integrity: added incoherent for Bus in ProcessConsistest

d32ac1c

fix_edsl: now can compile with BusNetwork instance of ProcessConsistent

175a769

Fix errors, which prevent building.

5374c50

ryukzak mentioned this pull request Feb 20, 2022

Check integrity for process units #202

Merged

ryukzak closed this Mar 7, 2022

ryukzak deleted the 72-integrity-check branch March 7, 2022 17:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat_integrity: added check integrity: functions should be present in… #98

feat_integrity: added check integrity: functions should be present in… #98

co0ll3r commented Mar 17, 2021 •

edited

Loading

ryukzak left a comment

ryukzak left a comment

ryukzak Mar 31, 2021

ryukzak Mar 31, 2021

ryukzak left a comment

ryukzak Apr 7, 2021

ryukzak commented Mar 7, 2022

ryukzak commented Mar 7, 2022

feat_integrity: added check integrity: functions should be present in… #98

feat_integrity: added check integrity: functions should be present in… #98

Conversation

co0ll3r commented Mar 17, 2021 • edited Loading

ryukzak left a comment

Choose a reason for hiding this comment

ryukzak left a comment

Choose a reason for hiding this comment

ryukzak Mar 31, 2021

Choose a reason for hiding this comment

ryukzak Mar 31, 2021

Choose a reason for hiding this comment

ryukzak left a comment

Choose a reason for hiding this comment

ryukzak Apr 7, 2021

Choose a reason for hiding this comment

ryukzak commented Mar 7, 2022

ryukzak commented Mar 7, 2022

co0ll3r commented Mar 17, 2021 •

edited

Loading