Update Acc32.hs #24
Open
Update Acc32.hs #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the text description of some commands. We don't work with values directly.
ryukzak
requested changes
Dec 13, 2024
| @@ -26,7 +26,7 @@ instance Hashable Register | |||
| -- | The 'Isa' type represents the instruction set architecture for the Acc32 machine. | |||
| -- Each constructor corresponds to a specific instruction. | |||
| data Isa w l | |||
| = -- | Syntax: @load_imm <value>@ Load an immediate value into the accumulator. | |||
| = -- | Syntax: @load_imm <address>@ Load an immediate value into the accumulator. | |||
There was a problem hiding this comment.
Sure? Maybe here it is an value?
There was a problem hiding this comment.
Yeah, I'm a sure about that. There is usage example:
load_imm buf
Also in the code for load_imm we have:
LoadImm l -> LoadImm (deref' f l)
And the command realisation:
LoadImm a -> setAcc a >> nextPc
So we understand that the command receives the address of the label and loads this address value into the acc, but we can't directly load a value, because of the "deref' f l" instruction.
Maybe it should be like that:
Syntax: @load_imm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the text description of some commands. We don't work with values directly.