Templates #5
Merged
Templates #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
not sure about contributing.md, maybe its not necessary :) |
fizruk
previously approved these changes
Sep 14, 2023
fizruk
approved these changes
Sep 14, 2023
fizruk
reviewed
Sep 14, 2023
|
|
||
| ## Code style | ||
|
|
||
| [This](https://github.com/emilyriehl/yoneda/blob/master/STYLEGUIDE.md) style guide can be followed. |
There was a problem hiding this comment.
I don't think we (will) follow that style guide entirely. In particular, we might want to keep the names used in the book as is, to stay closer to it and assist with readability (when reading formalisations and comparing against the book). But we can keep the reference to that style guide for now. Also, see #6.
There was a problem hiding this comment.
I will merge, despite the comment above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chapter and exercise templates for uniform structure of contributions