Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add test cases and CI pipeline #3

Merged
merged 18 commits into from
Jul 11, 2024
Merged

test: Add test cases and CI pipeline #3

merged 18 commits into from
Jul 11, 2024

Conversation

moritzsommer
Copy link
Collaborator

@moritzsommer moritzsommer commented Jul 7, 2024

Previously, there were no unittests or CI in this
project.
This adds test cases for every functionality of
the semantic_id_resolver and its service.
Furthermore, this adds the corresponding
GitHub CI Workflows to run the tests.

Fixes #2

@moritzsommer moritzsommer linked an issue Jul 7, 2024 that may be closed by this pull request
Copy link
Owner

@s-heppner s-heppner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the requirements.txt, it looks good to me

requirements.txt Show resolved Hide resolved
Copy link
Owner

@s-heppner s-heppner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now

@s-heppner s-heppner changed the title wip/testing: add test cases and ci pipeline test: Add test cases and CI pipeline Jul 11, 2024
@s-heppner s-heppner merged commit 17812f4 into main Jul 11, 2024
6 checks passed
@s-heppner s-heppner deleted the wip/testing branch July 11, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

resolver: is_iri() does not properly check for IRDI
2 participants