Deps updated. #203
s3riusAnnotations
33 errors and 16 warnings
|
tests
Process completed with exit code 101.
|
|
match can be simplified with `.unwrap_or_default()`:
src/main.rs#L198
error: match can be simplified with `.unwrap_or_default()`
--> src/main.rs:198:35
|
198 | let url = match srv_response.request().match_pattern() {
| ___________________________________^
199 | | Some(pattern) => pattern,
200 | | None => String::new(),
201 | | };
| |_________________________^ help: replace it with: `srv_response.request().match_pattern().unwrap_or_default()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default
|
|
empty line after doc comment:
src/main.rs#L140
error: empty line after doc comment
--> src/main.rs:140:1
|
140 | / /// given address.
141 | |
| |_
142 | #[allow(clippy::too_many_lines)]
143 | pub fn create_server(state: State) -> RustusResult<Server> {
| ---------------------------------------------------------- the comment documents this function
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
= help: if the empty line is unintentional remove it
|
|
empty line after outer attribute:
src/routes.rs#L13
error: empty line after outer attribute
--> src/routes.rs:13:1
|
13 | / #[allow(clippy::unused_async)]
14 | |
| |_
15 | pub async fn health_check() -> HttpResponse {
| ------------------------------------------- the attribute applies to this function
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_outer_attr
= help: if the empty line is unintentional remove it
|
|
empty line after outer attribute:
src/routes.rs#L6
error: empty line after outer attribute
--> src/routes.rs:6:1
|
6 | / #[allow(clippy::unused_async)]
7 | |
| |_
8 | pub async fn not_found() -> HttpResponse {
| ---------------------------------------- the attribute applies to this function
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_outer_attr
= help: if the empty line is unintentional remove it
|
|
empty line after doc comment:
src/protocol/mod.rs#L14
error: empty line after doc comment
--> src/protocol/mod.rs:14:1
|
14 | / /// provided by CLI into services and adds it to the application.
15 | |
| |_
16 | pub fn setup(app_conf: RustusConf) -> impl Fn(&mut web::ServiceConfig) {
| ---------------------------------------------------------------------- the comment documents this function
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
= help: if the empty line is unintentional remove it
|
|
empty line after doc comment:
src/protocol/termination/mod.rs#L8
error: empty line after doc comment
--> src/protocol/termination/mod.rs:8:1
|
8 | / /// to terminate file upload.
9 | |
| |_
10 | pub fn add_extension(web_app: &mut web::ServiceConfig) {
| ------------------------------------------------------ the comment documents this function
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
= help: if the empty line is unintentional remove it
|
|
empty line after doc comment:
src/protocol/getting/mod.rs#L10
error: empty line after doc comment
--> src/protocol/getting/mod.rs:10:1
|
10 | / /// This is unofficial extension.
11 | |
| |_
12 | pub fn add_extension(web_app: &mut web::ServiceConfig) {
| ------------------------------------------------------ the comment documents this function
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
= help: if the empty line is unintentional remove it
|
|
empty line after doc comment:
src/protocol/creation/mod.rs#L7
error: empty line after doc comment
--> src/protocol/creation/mod.rs:7:1
|
7 | / /// to create file before sending data.
8 | |
| |_
9 | pub fn add_extension(web_app: &mut web::ServiceConfig) {
| ------------------------------------------------------ the comment documents this function
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
= help: if the empty line is unintentional remove it
|
|
empty line after doc comment:
src/protocol/core/mod.rs#L14
error: empty line after doc comment
--> src/protocol/core/mod.rs:14:1
|
14 | / /// PATCH /api/file - to add bytes to file.
15 | |
| |_
16 | pub fn add_extension(web_app: &mut web::ServiceConfig) {
| ------------------------------------------------------ the comment documents this function
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
= help: if the empty line is unintentional remove it
|
|
name `AMQP` contains a capitalized acronym:
src/notifiers/manager.rs#L24
error: name `AMQP` contains a capitalized acronym
--> src/notifiers/manager.rs:24:5
|
24 | AMQP(AMQPNotifier),
| ^^^^ help: consider making the acronym lowercase, except the initial letter: `Amqp`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
= note: `-D clippy::upper-case-acronyms` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::upper_case_acronyms)]`
|
|
item name ends with its containing module's name:
src/notifiers/manager.rs#L15
error: item name ends with its containing module's name
--> src/notifiers/manager.rs:15:12
|
15 | pub struct NotificationManager {
| ^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_name_repetitions
|
|
this argument (1 byte) is passed by reference, but would be more efficient if passed by value (limit: 8 byte):
src/notifiers/impls/amqp_notifier.rs#L101
error: this argument (1 byte) is passed by reference, but would be more efficient if passed by value (limit: 8 byte)
--> src/notifiers/impls/amqp_notifier.rs:101:40
|
101 | pub fn get_queue_name(&self, hook: &Hook) -> String {
| ^^^^^ help: consider passing by value instead: `Hook`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
= note: `-D clippy::trivially-copy-pass-by-ref` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::trivially_copy_pass_by_ref)]`
|
|
empty line after doc comment:
src/info_storage/mod.rs#L31
error: empty line after doc comment
--> src/info_storage/mod.rs:31:5
|
31 | / ///
32 | |
| |_
33 | pub fn get(&self, config: &RustusConf) -> RustusResult<InfoStorageImpl> {
| ----------------------------------------------------------------------- the comment documents this method
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
= help: if the empty line is unintentional remove it
|
|
item name starts with its containing module's name:
src/info_storage/mod.rs#L21
error: item name starts with its containing module's name
--> src/info_storage/mod.rs:21:10
|
21 | pub enum InfoStorageImpl {
| ^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_name_repetitions
|
|
item in documentation is missing backticks:
src/info_storage/base.rs#L18
error: item in documentation is missing backticks
--> src/info_storage/base.rs:18:59
|
18 | /// about given upload so it can be accessed again by file_id.
| ^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
help: try
|
18 | /// about given upload so it can be accessed again by `file_id`.
| ~~~~~~~~~
|
|
match can be simplified with `.unwrap_or_default()`:
src/file_info.rs#L50
error: match can be simplified with `.unwrap_or_default()`
--> src/file_info.rs:50:24
|
50 | let metadata = match initial_metadata {
| ________________________^
51 | | Some(meta) => meta,
52 | | None => HashMap::new(),
53 | | };
| |_________^ help: replace it with: `initial_metadata.unwrap_or_default()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default
= note: `-D clippy::manual-unwrap-or-default` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::manual_unwrap_or_default)]`
|
|
empty line after doc comment:
src/errors.rs#L80
error: empty line after doc comment
--> src/errors.rs:80:1
|
80 | / /// Trait to convert errors to http-responses.
81 | |
| |_
82 | impl ResponseError for RustusError {
| ---------------------------------- the comment documents this implementation
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
= help: if the empty line is unintentional remove it
|
|
empty line after doc comment:
src/errors.rs#L72
error: empty line after doc comment
--> src/errors.rs:72:1
|
72 | / /// This conversion allows us to use `RustusError` in the `main` function.
73 | |
| |_
74 | impl From<RustusError> for Error {
| -------------------------------- the comment documents this implementation
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
= help: if the empty line is unintentional remove it
|
|
it is more idiomatic to use `Option<&T>` instead of `&Option<T>`:
src/data_storage/mod.rs#L74
error: it is more idiomatic to use `Option<&T>` instead of `&Option<T>`
--> src/data_storage/mod.rs:74:1
|
74 | / fn from_string_or_path(variable: &Option<String>, path: &Option<PathBuf>) -> String {
75 | | if let Some(variable) = variable {
76 | | variable.to_string()
77 | | } else if let Some(path) = path {
... |
87 | | }
88 | | }
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_option
help: change this to
|
74 | fn from_string_or_path(variable: Option<&String>, path: Option<&PathBuf>) -> String {
| ~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~
|
|
empty line after doc comment:
src/data_storage/mod.rs#L33
error: empty line after doc comment
--> src/data_storage/mod.rs:33:5
|
33 | / ///
34 | |
| |_
35 | pub fn get(&self, config: &RustusConf) -> DataStorageImpl {
| --------------------------------------------------------- the comment documents this method
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
= note: `-D clippy::empty-line-after-doc-comments` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::empty_line_after_doc_comments)]`
= help: if the empty line is unintentional remove it
|
|
item name starts with its containing module's name:
src/data_storage/mod.rs#L22
error: item name starts with its containing module's name
--> src/data_storage/mod.rs:22:10
|
22 | pub enum DataStorageImpl {
| ^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_name_repetitions
|
|
this manual char comparison can be written more succinctly:
src/data_storage/impls/s3_hybrid.rs#L119
error: this manual char comparison can be written more succinctly
--> src/data_storage/impls/s3_hybrid.rs:119:55
|
119 | let trimmed_path = base_path.trim_end_matches(|c: char| c == '/');
| ^^^^^^^^^^^^^^^^^^ help: consider using a `char`: `'/'`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_pattern_char_comparison
= note: `-D clippy::manual-pattern-char-comparison` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::manual_pattern_char_comparison)]`
|
|
it is more idiomatic to use `Option<&T>` instead of `&Option<T>`:
src/data_storage/impls/s3_hybrid.rs#L38
error: it is more idiomatic to use `Option<&T>` instead of `&Option<T>`
--> src/data_storage/impls/s3_hybrid.rs:38:5
|
38 | / pub fn new(
39 | | endpoint: String,
40 | | region: String,
41 | | access_key: &Option<String>,
... |
93 | | }
94 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_option
= note: `-D clippy::ref-option` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::ref_option)]`
help: change this to
|
41 ~ access_key: Option<&String>,
42 ~ secret_key: Option<&String>,
43 ~ security_token: Option<&String>,
44 ~ session_token: Option<&String>,
45 ~ profile: Option<&String>,
46 ~ custom_headers: Option<&String>,
|
|
|
item name starts with its containing module's name:
src/data_storage/impls/s3_hybrid.rs#L30
error: item name starts with its containing module's name
--> src/data_storage/impls/s3_hybrid.rs:30:12
|
30 | pub struct S3HybridDataStorage {
| ^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_name_repetitions
= note: `-D clippy::module-name-repetitions` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::module_name_repetitions)]`
|
|
unnecessary use of `.write(true)` because there is `.append(true)`:
src/data_storage/impls/file_storage.rs#L161
error: unnecessary use of `.write(true)` because there is `.append(true)`
--> src/data_storage/impls/file_storage.rs:161:17
|
161 | .write(true)
| ^^^^^^^^^^^^ help: remove `.write(true)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ineffective_open_options
|
|
unnecessary use of `.write(true)` because there is `.append(true)`:
src/data_storage/impls/file_storage.rs#L109
error: unnecessary use of `.write(true)` because there is `.append(true)`
--> src/data_storage/impls/file_storage.rs:109:17
|
109 | .write(true)
| ^^^^^^^^^^^^ help: remove `.write(true)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ineffective_open_options
= note: `-D clippy::ineffective-open-options` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::ineffective_open_options)]`
|
|
item in documentation is missing backticks:
src/data_storage/base.rs#L24
error: item in documentation is missing backticks
--> src/data_storage/base.rs:24:33
|
24 | /// This method must return HttpResponse.
| ^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
help: try
|
24 | /// This method must return `HttpResponse`.
| ~~~~~~~~~~~~~~
|
|
item in documentation is missing backticks:
src/config.rs#L214
error: item in documentation is missing backticks
--> src/config.rs:214:43
|
214 | /// Maximum number of connections for RabbitMQ.
| ^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
help: try
|
214 | /// Maximum number of connections for `RabbitMQ`.
| ~~~~~~~~~~
|
|
all fields have the same prefix: `hooks_amqp`:
src/config.rs#L168
error: all fields have the same prefix: `hooks_amqp`
--> src/config.rs:168:1
|
168 | / pub struct AMQPHooksOptions {
169 | | /// Url for AMQP server.
170 | | #[arg(long, env = "RUSTUS_HOOKS_AMQP_URL")]
171 | | pub hooks_amqp_url: Option<String>,
... |
236 | | pub hooks_amqp_idle_channels_timeout: Option<u64>,
237 | | }
| |_^
|
= help: remove the prefixes
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#struct_field_names
= note: `-D clippy::struct-field-names` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::struct_field_names)]`
|
|
empty line after outer attribute:
src/config.rs#L166
error: empty line after outer attribute
--> src/config.rs:166:1
|
166 | / #[allow(clippy::struct_excessive_bools)]
167 | |
| |_
168 | pub struct AMQPHooksOptions {
| --------------------------- the attribute applies to this struct
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_outer_attr
= note: `-D clippy::empty-line-after-outer-attr` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::empty_line_after_outer_attr)]`
= help: if the empty line is unintentional remove it
|
|
item in documentation is missing backticks:
src/config.rs#L24
error: item in documentation is missing backticks
--> src/config.rs:24:18
|
24 | /// for all *file_storage storages.
| ^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
= note: `-D clippy::doc-markdown` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::doc_markdown)]`
help: try
|
24 | /// for all *`file_storage` storages.
| ~~~~~~~~~~~~~~
|
|
code_check
Clippy had exited with the 101 exit code
|
|
pre_job
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
fmt_check
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
fmt_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
fmt_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
fmt_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
fmt_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
tests
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
tests
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
tests
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
tests
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
tests
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
code_check
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
code_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
code_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
code_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
code_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|