Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to stable + Fix CORS #149

Merged
merged 2 commits into from
May 8, 2024
Merged

Conversation

reneklacan
Copy link
Contributor

  • Switch to stable Rust
    • The only thing that needed nightly was rustfmt's imports_granularity which I
      believe is small price to pay for switching to stable
  • Fix CORS preflight requests (info on options conflicted with CORS
    layer preflight logic and was breaking web JS client) by moving info
    headers to included in all requests

- Switch to stable Rust
  - The only thing that needed nightly was rustfmt's imports_granularity which I
    believe is small price to pay for switching to stable
- Fix CORS preflight requests (info on options conflicted with CORS
  layer preflight logic and was breaking web JS client) by moving info
  headers to included in all requests
@s3rius
Copy link
Owner

s3rius commented May 8, 2024

Thanks you very much. If you tried to fix rustus that is published on docker hub, then it won't work, because version on master branch is different to what is published on hub.

I will try to update the project and will publish it on hub this or next week.

@reneklacan
Copy link
Contributor Author

@s3rius version in dockerhub actually worked ok but then when I switched to building image from latest code (develop branch), I ran into CORS issues and these changes fixed them

@reneklacan
Copy link
Contributor Author

@s3rius do you want me to fix failing lint or do you just plan to address this in a different way? I'm fine either way!

@s3rius
Copy link
Owner

s3rius commented May 8, 2024

I'd love if you will fix it.

@reneklacan
Copy link
Contributor Author

@s3rius cool, pushed fixes

@s3rius
Copy link
Owner

s3rius commented May 8, 2024

Seems good to me.

@s3rius s3rius merged commit 1cb5928 into s3rius:develop May 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants