Add authentication & reactions #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jvm-odoo Amazing Work 😀. I guess we should also update the readme.md with this that how can user create Github client secret and id and what should be the redirect url. |
saadpasta
reviewed
Mar 2, 2020
saadpasta
reviewed
Mar 2, 2020
| return ""; | ||
| } | ||
| }, []); | ||
| const reactionsContainer = useRef(null); |
There was a problem hiding this comment.
To force the reactions to refresh when adding/removing one
There was a problem hiding this comment.
OK, so we call API again to get the reactions or we update it manually
There was a problem hiding this comment.
Yes, I managed to use minimum API calls as possible in order to improve performances
saadpasta
reviewed
Mar 2, 2020
saadpasta
requested changes
Mar 2, 2020
|
I will update the readme asap! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added authentication & reactions
Documentation need to be updated to explain how to set this thing up (create a github app with write access on the blog repository, not OAuth app. And with homepage & callback =
https://username.github.io/react-blog-github/)Things to note:
Finally, it improves some things & delete unused files.
Extra note: I was forced to put
https://username.github.io/react-blog-github/as callback because github doesn't support # in urlsWorking example: https://jvm-odoo.github.io/react-blog-github/#/
If you see any thing to improve do not hesitate to comment!
Related issue #26