refactor: reduce mock signature complexity

safe-global · Mar 7, 2025 · 241c1aa · 241c1aa
1 parent 4b20e69
commit 241c1aa
Show file tree

Hide file tree

Showing 7 changed files with 228 additions and 242 deletions.
diff --git a/src/domain/messages/helpers/message-verifier.helper.spec.ts b/src/domain/messages/helpers/message-verifier.helper.spec.ts
@@ -252,7 +252,7 @@ describe('MessageVerifierHelper', () => {
             safe,
             message: message.message,
             messageHash: message.messageHash,
-            signature: `0x--------------------------------------------------------------------------------------------------------------------------------${v}`,
+            signature: `0x${'-'.repeat(128)}${v}`,
           });
         }).toThrow(new HttpExceptionNoLog('Could not recover address', 422));
 
@@ -610,7 +610,7 @@ describe('MessageVerifierHelper', () => {
             safe,
             message: message.message,
             messageHash: message.messageHash,
-            signature: `0x--------------------------------------------------------------------------------------------------------------------------------${v}`,
+            signature: `0x${'-'.repeat(128)}${v}`,
           });
         }).toThrow(new HttpExceptionNoLog('Could not recover address', 422));
 

diff --git a/src/routes/messages/messages.controller.spec.ts b/src/routes/messages/messages.controller.spec.ts
@@ -1035,10 +1035,7 @@ describe('Messages controller', () => {
             .send(
               createMessageDtoBuilder()
                 .with('message', message.message)
-                .with(
-                  'signature',
-                  `0x--------------------------------------------------------------------------------------------------------------------------------${v}`,
-                )
+                .with('signature', `0x${'-'.repeat(128)}${v}`)
                 .build(),
             )
             .expect(422)
@@ -1568,10 +1565,7 @@ describe('Messages controller', () => {
             )
             .send(
               updateMessageSignatureDtoBuilder()
-                .with(
-                  'signature',
-                  `0x--------------------------------------------------------------------------------------------------------------------------------${v}`,
-                )
+                .with('signature', `0x${'-'.repeat(128)}${v}`)
                 .build(),
             )
             .expect(422)

diff --git a/...tions/__tests__/controllers/add-transaction-confirmations.transactions.controller.spec.ts b/...tions/__tests__/controllers/add-transaction-confirmations.transactions.controller.spec.ts
@@ -509,10 +509,7 @@ describe('Add transaction confirmations - Transactions Controller (Unit)', () =>
         ) as MultisigTransaction;
         const v = transaction.confirmations![0].signature?.slice(-2);
         const addConfirmationDto = addConfirmationDtoBuilder()
-          .with(
-            'signature',
-            `0x--------------------------------------------------------------------------------------------------------------------------------${v}`,
-          )
+          .with('signature', `0x${'-'.repeat(128)}${v}`)
           .build();
 
         await request(app.getHttpServer())

diff --git a/.../transactions/__tests__/controllers/get-transaction-by-id.transactions.controller.spec.ts b/.../transactions/__tests__/controllers/get-transaction-by-id.transactions.controller.spec.ts
@@ -1392,7 +1392,7 @@ describe('Get by id - Transactions Controller (Unit)', () => {
             signatureType,
           });
         const v = multisigTransaction.confirmations![0].signature?.slice(-2);
-        multisigTransaction.confirmations![0].signature = `0x--------------------------------------------------------------------------------------------------------------------------------${v}`;
+        multisigTransaction.confirmations![0].signature = `0x${'-'.repeat(128)}${v}`;
 
         const getSafeUrl = `${chain.transactionService}/api/v1/safes/${safe.address}`;
         const getChainUrl = `${safeConfigUrl}/api/v1/chains/${chain.chainId}`;

diff --git a/...ns/__tests__/controllers/list-queued-transactions-by-safe.transactions.controller.spec.ts b/...ns/__tests__/controllers/list-queued-transactions-by-safe.transactions.controller.spec.ts
@@ -1077,7 +1077,7 @@ describe('List queued transactions by Safe - Transactions Controller (Unit)', ()
         };
         const nonce1 = await getTransaction(1);
         const v = nonce1.confirmations![0].signature?.slice(-2);
-        nonce1.confirmations![0].signature = `0x--------------------------------------------------------------------------------------------------------------------------------${v}`;
+        nonce1.confirmations![0].signature = `0x${'-'.repeat(128)}${v}`;
         const nonce2 = await getTransaction(2);
         const transactions: Array<MultisigTransaction> = [
           multisigToJson(nonce1) as MultisigTransaction,