fix: improve test robustness

safe-global · Mar 3, 2025 · cb13325 · cb13325
1 parent e4360d5
commit cb13325
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/src/routes/common/filters/global-error.filter.spec.ts b/src/routes/common/filters/global-error.filter.spec.ts
@@ -73,7 +73,9 @@ describe('GlobalErrorFilter tests', () => {
 
   describe('responses', () => {
     it('http exception returns correct error code and message', async () => {
-      const code = faker.internet.httpStatusCode();
+      const code = faker.internet.httpStatusCode({
+        types: ['clientError', 'serverError'],
+      });
 
       await request(app.getHttpServer())
         .post('/http-exception')
@@ -83,7 +85,9 @@ describe('GlobalErrorFilter tests', () => {
     });
 
     it('no log http exception returns correct error code and message', async () => {
-      const code = faker.internet.httpStatusCode();
+      const code = faker.internet.httpStatusCode({
+        types: ['clientError', 'serverError'],
+      });
 
       await request(app.getHttpServer())
         .post('/no-log-http-exception')
@@ -123,7 +127,7 @@ describe('GlobalErrorFilter tests', () => {
 
     it('should log non-server errors as info', async () => {
       const code = faker.internet.httpStatusCode({
-        types: ['informational', 'success', 'clientError', 'redirection'],
+        types: ['clientError'],
       });
 
       await request(app.getHttpServer())
@@ -141,7 +145,9 @@ describe('GlobalErrorFilter tests', () => {
     });
 
     it('should not log no log http exception', async () => {
-      const code = faker.internet.httpStatusCode();
+      const code = faker.internet.httpStatusCode({
+        types: ['clientError', 'serverError'],
+      });
 
       await request(app.getHttpServer())
         .post('/no-log-http-exception')