Create token-specific entities #2309
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamacook
commented
Jan 28, 2025
Comment on lines
+17
to
+27
| type: z.literal('NATIVE_TOKEN'), | ||
| decimals: z.number(), | ||
| }); | ||
|
|
||
| const Erc20TokenSchema = BaseTokenSchema.extend({ | ||
| type: z.literal('ERC20'), | ||
| decimals: z.number().catch(DEFAULT_ERC20_DECIMALS), | ||
| }); | ||
|
|
||
| const Erc721TokenSchema = BaseTokenSchema.extend({ | ||
| type: z.literal('ERC721'), |
There was a problem hiding this comment.
String types are now preferred due to type complaints when using different enums from the domain vs. route layers.
iamacook
commented
Jan 28, 2025
| Erc20 = 'ERC20', | ||
| NativeToken = 'NATIVE_TOKEN', | ||
| } | ||
| import { z } from 'zod'; |
There was a problem hiding this comment.
This is the "core" change, from which everything else implemented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #2307
We currently parse native, ERC-20 and ERC-721 tokens as one, meaning we cannot safely assume decimals should they not exist.
This splits
TokenSchemainto three specific schemas per token type with the following assumptions:From the parsed token, token-specific entities are mapped for Swagger.
Changes
TokenSchemaintoNativeTokenSchema,Erc20TokenSchemaandErc721TokenSchema